Expand the JsonPrefStore's interface to allow for an alternate filename to be specified.

chrome/common/chrome_constants.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // A handful of resource-like constants related to the Chrome application.
 
 #ifndef CHROME_COMMON_CHROME_CONSTANTS_H_
 #define CHROME_COMMON_CHROME_CONSTANTS_H_
 
 #include "base/files/file_path.h"
@@ skipping 58 matching lines @@
 extern const base::FilePath::CharType kHistoryFilename[];
 extern const base::FilePath::CharType kJumpListIconDirname[];
 extern const base::FilePath::CharType kLocalStateFilename[];
 extern const base::FilePath::CharType kLocalStorePoolName[];
 extern const base::FilePath::CharType kLoginDataFileName[];
 extern const base::FilePath::CharType kSupervisedUserSettingsFilename[];
 extern const base::FilePath::CharType kMediaCacheDirname[];
 extern const base::FilePath::CharType kNewTabThumbnailsFilename[];
 extern const base::FilePath::CharType kOBCertFilename[];
 extern const base::FilePath::CharType kPreferencesFilename[];
-extern const base::FilePath::CharType kProtectedPreferencesFilename[];
+extern const base::FilePath::CharType kDeprecatedProtectedPreferencesFilename[];
+extern const base::FilePath::CharType kSecurePreferencesFilename[];

[Bernhard Bauer, 2014/06/19 15:38:09]

Move this down so the constants stay in alphabetical order?

[gab, 2014/06/19 16:03:52]

I debated that, but I opted to have them side-by-side; FWIW this list is already
not quite alphabetically sorted (i.e. kSupervisedUserSettingsFilename).

I don't really care, if you feel strongly I'll make the change; it just felt
like having kPref.., kDeprecatedProtectedPref.., and kSecurePref.. together was
easier to read.

[sky, 2014/06/19 16:03:58]

+1

[Bernhard Bauer, 2014/06/19 17:20:20]

I do prefer alphabetic.

The kSupervisedUserSettingsFilename is an artifact of a recent renaming, which
I'm about to fix :)

[gab, 2014/06/19 17:50:10]

Done (and changed kDeprecatedProtectedPreferencesFilename to
kProtectedPreferencesFilenameDeprecated so that it at least doesn't end up alone
at the top).

 extern const base::FilePath::CharType kReadmeFilename[];
 extern const base::FilePath::CharType kResetPromptMementoFilename[];
 extern const base::FilePath::CharType kSafeBrowsingBaseFilename[];
 extern const base::FilePath::CharType kServiceStateFileName[];
 extern const base::FilePath::CharType kShortcutsDatabaseName[];
 extern const base::FilePath::CharType kSingletonCookieFilename[];
 extern const base::FilePath::CharType kSingletonLockFilename[];
 extern const base::FilePath::CharType kSingletonSocketFilename[];
 extern const base::FilePath::CharType kSyncCredentialsFilename[];
 extern const base::FilePath::CharType kThemePackFilename[];
@@ skipping 69 matching lines @@
 extern const char kApplicationClientIDStringForAVScanning[];
 
 #if defined(OS_ANDROID)
 // The largest reasonable length we'd assume for a meta tag attribute.
 extern const size_t kMaxMetaTagAttributeLength;
 #endif
 
 }  // namespace chrome
 
 #endif  // CHROME_COMMON_CHROME_CONSTANTS_H_