Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Unified Diff: Source/bindings/templates/attributes.cpp

Issue 347773003: IDL: Remove holder lookup in attribute_getter macro (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/tests/results/V8TestObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/templates/attributes.cpp
diff --git a/Source/bindings/templates/attributes.cpp b/Source/bindings/templates/attributes.cpp
index 225b6dedf5e53bfa71d09b3550e8ce1afdbbae10..e7393c1a409ff84431f950c7336801b24634aa35 100644
--- a/Source/bindings/templates/attributes.cpp
+++ b/Source/bindings/templates/attributes.cpp
@@ -13,13 +13,7 @@ const v8::PropertyCallbackInfo<v8::Value>& info
{% set cpp_class, v8_class = 'Element', 'V8Element' %}
{% endif %}
{# holder #}
- {% if attribute.is_unforgeable and interface_name != 'Window' %}
- {# perform lookup first #}
- {# FIXME: can we remove this lookup? #}
- v8::Handle<v8::Object> holder = {{v8_class}}::findInstanceInPrototypeChain(info.This(), info.GetIsolate());
- if (holder.IsEmpty())
- return;
- {% elif not attribute.is_static %}
+ {% if not attribute.is_static %}
v8::Handle<v8::Object> holder = info.Holder();
{% endif %}
{# impl #}
« no previous file with comments | « no previous file | Source/bindings/tests/results/V8TestObject.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698