Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(938)

Unified Diff: Source/core/html/HTMLOptionElement.h

Issue 347773002: Implement select listbox using shadow DOM (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/HTMLOptGroupElement.cpp ('k') | Source/core/html/HTMLOptionElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLOptionElement.h
diff --git a/Source/core/html/HTMLOptionElement.h b/Source/core/html/HTMLOptionElement.h
index e5de12508fd1ac6de5ae723e32030f0c2075f788..31b91e187e9b6f602acc5ff21b4f6c6daafd9574 100644
--- a/Source/core/html/HTMLOptionElement.h
+++ b/Source/core/html/HTMLOptionElement.h
@@ -65,22 +65,18 @@ public:
void setSelectedState(bool);
HTMLFormElement* form() const;
-
- bool isDisplayNone() const;
+ bool spatialNavigationFocused() const;
private:
explicit HTMLOptionElement(Document&);
- virtual bool rendererIsFocusable() const OVERRIDE;
- virtual bool rendererIsNeeded(const RenderStyle&) OVERRIDE { return false; }
+ virtual bool rendererIsFocusable() const OVERRIDE { return true; }
virtual void attach(const AttachContext& = AttachContext()) OVERRIDE;
virtual void detach(const AttachContext& = AttachContext()) OVERRIDE;
-
virtual void parseAttribute(const QualifiedName&, const AtomicString&) OVERRIDE;
-
virtual InsertionNotificationRequest insertedInto(ContainerNode*) OVERRIDE;
+ virtual void removedFrom(ContainerNode*) OVERRIDE;
virtual void accessKeyAction(bool) OVERRIDE;
-
virtual void childrenChanged(const ChildrenChange&) OVERRIDE;
// <option> never has a renderer so we manually manage a cached style.
@@ -88,9 +84,12 @@ private:
virtual RenderStyle* nonRendererStyle() const OVERRIDE;
virtual PassRefPtr<RenderStyle> customStyleForRenderer() OVERRIDE;
virtual void didRecalcStyle(StyleRecalcChange) OVERRIDE;
+ virtual void didAddUserAgentShadowRoot(ShadowRoot&) OVERRIDE;
String collectOptionInnerText() const;
+ void updateLabel();
+
bool m_disabled;
bool m_isSelected;
RefPtr<RenderStyle> m_style;
« no previous file with comments | « Source/core/html/HTMLOptGroupElement.cpp ('k') | Source/core/html/HTMLOptionElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698