LayoutTests/fast/forms/select-clientheight-large-size.html - Issue 347773002: Implement select listbox using shadow DOM

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/forms/select-clientheight-large-size.html

Issue 347773002: Implement select listbox using shadow DOM (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: LayoutTests/fast/forms/select-clientheight-large-size.html

diff --git a/LayoutTests/fast/forms/select-clientheight-large-size.html b/LayoutTests/fast/forms/select-clientheight-large-size.html

index 80d9c357a0418197594793a973fe3fe41dab96ba..fb10adb7e0b8aeb93cc4a9f17a07bf246f8357a4 100644

--- a/LayoutTests/fast/forms/select-clientheight-large-size.html

+++ b/LayoutTests/fast/forms/select-clientheight-large-size.html

@@ -13,7 +13,7 @@

}

function multipleOfElement(elemId, multiple) {

- return clientHeight(elemId) * multiple + (multiple - 1);

+ return clientHeight(elemId) * multiple;

}

function addSelect(id, numOptions)

@@ -31,7 +31,7 @@

shouldBe("clientHeight('select2')", "clientHeight('select1')");

shouldBeTrue("getElemById('select2').setAttribute('size', '4'); clientHeight('select2') == clientHeight('select1')");

shouldBeTrue("getElemById('select2').setAttribute('size', '5'); clientHeight('select2') > clientHeight('select1')");

- shouldBeTrue("getElemById('select2').setAttribute('size', '8'); clientHeight('select2') == multipleOfElement('select1', 2)");

- shouldBeTrue("getElemById('select2').setAttribute('size', '12'); clientHeight('select2') == multipleOfElement('select1', 3)");

- shouldBeTrue("getElemById('select2').setAttribute('size', '16'); clientHeight('select2') == multipleOfElement('select1', 4)");

+ shouldBeCloseTo("getElemById('select2').setAttribute('size', '8'); clientHeight('select2')", multipleOfElement('select1', 2), 1);

+ shouldBeCloseTo("getElemById('select2').setAttribute('size', '12'); clientHeight('select2')", multipleOfElement('select1', 3), 1);

+ shouldBeCloseTo("getElemById('select2').setAttribute('size', '16'); clientHeight('select2')", multipleOfElement('select1', 4), 1);

</script>