Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1032)

Unified Diff: Source/core/html/HTMLOptionElement.h

Issue 347773002: Implement select listbox using shadow DOM (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/HTMLOptionElement.h
diff --git a/Source/core/html/HTMLOptionElement.h b/Source/core/html/HTMLOptionElement.h
index 65e1a2394b84a80e0c9830f0733ae5e09ac76152..91eec79fb50ae945f0b022d396af8cbe90db908f 100644
--- a/Source/core/html/HTMLOptionElement.h
+++ b/Source/core/html/HTMLOptionElement.h
@@ -66,31 +66,28 @@ public:
HTMLFormElement* form() const;
- bool isDisplayNone() const;
-
private:
explicit HTMLOptionElement(Document&);
- virtual bool rendererIsFocusable() const OVERRIDE;
- virtual bool rendererIsNeeded(const RenderStyle&) OVERRIDE { return false; }
+ virtual bool rendererIsFocusable() const OVERRIDE { return true; }
virtual void attach(const AttachContext& = AttachContext()) OVERRIDE;
virtual void detach(const AttachContext& = AttachContext()) OVERRIDE;
-
virtual void parseAttribute(const QualifiedName&, const AtomicString&) OVERRIDE;
-
virtual InsertionNotificationRequest insertedInto(ContainerNode*) OVERRIDE;
+ virtual void removedFrom(ContainerNode*) OVERRIDE;
virtual void accessKeyAction(bool) OVERRIDE;
-
virtual void childrenChanged(bool changedByParser = false, Node* beforeChange = 0, Node* afterChange = 0, int childCountDelta = 0) OVERRIDE;
-
// <option> never has a renderer so we manually manage a cached style.
void updateNonRenderStyle();
virtual RenderStyle* nonRendererStyle() const OVERRIDE;
virtual PassRefPtr<RenderStyle> customStyleForRenderer() OVERRIDE;
virtual void didRecalcStyle(StyleRecalcChange) OVERRIDE;
+ virtual void didAddUserAgentShadowRoot(ShadowRoot&) OVERRIDE;
String collectOptionInnerText() const;
+ void updateLabel();
+
bool m_disabled;
bool m_isSelected;
RefPtr<RenderStyle> m_style;

Powered by Google App Engine
This is Rietveld 408576698