Source/core/rendering/RenderThemeChromiumMac.mm - Issue 347773002: Implement select listbox using shadow DOM

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderThemeChromiumMac.mm

Issue 347773002: Implement select listbox using shadow DOM (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fixed Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/RenderThemeChromiumMac.mm

diff --git a/Source/core/rendering/RenderThemeChromiumMac.mm b/Source/core/rendering/RenderThemeChromiumMac.mm

index 17d3c4d512777c3168376d14115ae6233e2799bf..9a00ec923eee6e05d9862abc60c8b14d23d8bfa5 100644

--- a/Source/core/rendering/RenderThemeChromiumMac.mm

+++ b/Source/core/rendering/RenderThemeChromiumMac.mm

@@ -511,7 +511,7 @@ Color RenderThemeChromiumMac::systemColor(CSSValueID cssValueId) const

bool RenderThemeChromiumMac::isControlStyled(const RenderStyle* style, const CachedUAStyle* uaStyle) const

{

ASSERT(uaStyle);

- if (style->appearance() == TextFieldPart || style->appearance() == TextAreaPart || style->appearance() == ListboxPart)

+ if (style->appearance() == TextFieldPart || style->appearance() == TextAreaPart)

return style->border() != uaStyle->border || style->boxShadow();

// FIXME: This is horrible, but there is not much else that can be done. Menu lists cannot draw properly when