LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-listbox.html - Issue 347773002: Implement select listbox using shadow DOM

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-listbox.html

Issue 347773002: Implement select listbox using shadow DOM (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fixed Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/css/recalc-optgroup-inherit.html ('K') | « LayoutTests/fast/dom/HTMLKeygenElement/keygen.html ('k') | LayoutTests/fast/forms/listbox-hit-test-zoomed.html » ('j') | Source/core/css/resolver/SharedStyleFinder.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-listbox.html

diff --git a/LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-listbox.html b/LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-listbox.html

index b4259bf491da0d3aa4e495ab7dbf7ce5dd8bce16..bdff4dd44196e550f0094d57f826448a3f748dec 100644

--- a/LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-listbox.html

+++ b/LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-listbox.html

@@ -58,7 +58,7 @@

eventSender.gestureScrollEnd(0, 0);

debug("Flinging the list box should scroll the list, the scrolls should be locked to item boundaries");

- shouldBe('box.scrollTop', '2*itemHeight');

+ shouldBe('box.scrollTop', '2*itemHeight+10');

shouldBe('container.scrollTop', '0');

resetScroll();

@@ -103,7 +103,7 @@

eventSender.gestureScrollEnd(0, 0);

debug("Gesture scrolling list should scroll the list, the scrolls should lock to item boundaries");

- shouldBe('box.scrollTop', '3*itemHeight');

+ shouldBe('box.scrollTop', '3*itemHeight+6');

shouldBe('container.scrollTop', '0');

resetScroll();

@@ -145,7 +145,7 @@

{

box = document.getElementById("box");

container = document.getElementById("container");

- itemHeight = (box.clientHeight + 1) / box.size;

+ itemHeight = box.clientHeight / box.size;

fullyScrolled = box.scrollHeight - box.clientHeight;