LayoutTests/fast/forms/select-clientheight-large-size.html - Issue 347773002: Implement select listbox using shadow DOM

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/forms/select-clientheight-large-size.html

Issue 347773002: Implement select listbox using shadow DOM (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« LayoutTests/fast/forms/resources/select-live-pseudo-selectors.js ('K') | « LayoutTests/fast/forms/resources/select-live-pseudo-selectors.js ('k') | LayoutTests/fast/forms/select/listbox-overlay-scrollbar-expected.html » ('j') | LayoutTests/fast/forms/select/listbox-overlay-scrollbar-expected.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="../../resources/js-test.js"></script>	2 <script src="../../resources/js-test.js"></script>

3 <div id="output"></div>	3 <div id="output"></div>

4 <script>	4 <script>

5 description("Tests that select elements cap their size to the size attribute and to 4 when no size is specified.");	5 description("Tests that select elements cap their size to the size attribute and to 4 when no size is specified.");

6	6

7 function getElemById(elemId) {	7 function getElemById(elemId) {

8 return document.getElementById(elemId);	8 return document.getElementById(elemId);

9 }	9 }

10	10

11 function clientHeight(elemId) {	11 function clientHeight(elemId) {

12 return getElemById(elemId).clientHeight;	12 return getElemById(elemId).clientHeight;

13 }	13 }

14	14

15 function multipleOfElement(elemId, multiple) {

16 return clientHeight(elemId) * multiple + (multiple - 1);

17 }

18

19 function addSelect(id, numOptions)	15 function addSelect(id, numOptions)

20 {	16 {

21 var select = document.createElement("select2");	17 var select = document.createElement("select2");

22 var html = '<select multiple id="' + id + '">';	18 var html = '<select multiple id="' + id + '">';

23 for (var i = 0; i <= numOptions; i++)	19 for (var i = 0; i <= numOptions; i++)

24 html += '<option value="' + i + '">' + i + '</option>';	20 html += '<option value="' + i + '">' + i + '</option>';

25 getElemById('output').innerHTML += html + '</select>';	21 getElemById('output').innerHTML += html + '</select>';

26 }	22 }

27	23

28 addSelect('select1', 10);	24 addSelect('select1', 10);

29 addSelect('select2', 16);	25 addSelect('select2', 16);

30	26

31 shouldBe("clientHeight('select2')", "clientHeight('select1')");	27 shouldBe("clientHeight('select2')", "clientHeight('select1')");

32 shouldBeTrue("getElemById('select2').setAttribute('size', '4'); clientHeight ('select2') == clientHeight('select1')");	28 shouldBeTrue("getElemById('select2').setAttribute('size', '4'); clientHeight ('select2') == clientHeight('select1')");

33 shouldBeTrue("getElemById('select2').setAttribute('size', '5'); clientHeight ('select2') > clientHeight('select1')");	29 shouldBeTrue("getElemById('select2').setAttribute('size', '5'); clientHeight ('select2') > clientHeight('select1')");

34 shouldBeTrue("getElemById('select2').setAttribute('size', '8'); clientHeight ('select2') == multipleOfElement('select1', 2)");

35 shouldBeTrue("getElemById('select2').setAttribute('size', '12'); clientHeigh t('select2') == multipleOfElement('select1', 3)");

36 shouldBeTrue("getElemById('select2').setAttribute('size', '16'); clientHeigh t('select2') == multipleOfElement('select1', 4)");

37 </script>	30 </script>

OLD	NEW