Improve scrolling performance in OOP PDF

pdf/out_of_process_instance.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "pdf/out_of_process_instance.h"
 
 #include <algorithm>  // for min/max()
 #define _USE_MATH_DEFINES  // for M_PI
 #include <cmath>      // for log() and pow()
 #include <math.h>
@@ skipping 16 matching lines @@
 #include "ppapi/c/private/ppb_instance_private.h"
 #include "ppapi/c/private/ppp_pdf.h"
 #include "ppapi/c/trusted/ppb_url_loader_trusted.h"
 #include "ppapi/cpp/core.h"
 #include "ppapi/cpp/dev/memory_dev.h"
 #include "ppapi/cpp/dev/text_input_dev.h"
 #include "ppapi/cpp/dev/url_util_dev.h"
 #include "ppapi/cpp/module.h"
 #include "ppapi/cpp/point.h"
 #include "ppapi/cpp/private/pdf.h"
+#include "ppapi/cpp/private/var_private.h"
 #include "ppapi/cpp/rect.h"
 #include "ppapi/cpp/resource.h"
 #include "ppapi/cpp/url_request_info.h"
 #include "ppapi/cpp/var_array.h"
 #include "ppapi/cpp/var_dictionary.h"
 #include "ui/events/keycodes/keyboard_codes.h"
 
 #if defined(OS_MACOSX)
 #include "base/mac/mac_util.h"
 #endif
@@ skipping 16 matching lines @@
 const char kAccessibleLoaded[] = "loaded";
 const char kAccessibleCopyable[] = "copyable";
 
 // Constants used in handling postMessage() messages.
 const char* kType = "type";
 // Viewport message arguments. (Page -> Plugin).
 const char* kJSViewportType = "viewport";
 const char* kJSXOffset = "xOffset";
 const char* kJSYOffset = "yOffset";
 const char* kJSZoom = "zoom";
+// Stop scrolling message (Page -> Plugin)
+const char* kJSStopScrollingType = "stopScrolling";
 // Document dimension arguments (Plugin -> Page).
 const char* kJSDocumentDimensionsType = "documentDimensions";
 const char* kJSDocumentWidth = "width";
 const char* kJSDocumentHeight = "height";
 const char* kJSPageDimensions = "pageDimensions";
 const char* kJSPageX = "x";
 const char* kJSPageY = "y";
 const char* kJSPageWidth = "width";
 const char* kJSPageHeight = "height";
 // Document load progress arguments (Plugin -> Page)
@@ skipping 154 matching lines @@
       paint_manager_(this, this, true),
       first_paint_(true),
       document_load_state_(LOAD_STATE_LOADING),
       preview_document_load_state_(LOAD_STATE_COMPLETE),
       uma_(this),
       told_browser_about_unsupported_feature_(false),
       print_preview_page_count_(0),
       last_progress_sent_(0),
       recently_sent_find_update_(false),
       received_viewport_message_(false),
-      did_call_start_loading_(false) {
+      did_call_start_loading_(false),
+      stop_scrolling_(false) {
   loader_factory_.Initialize(this);
   timer_factory_.Initialize(this);
   form_factory_.Initialize(this);
   print_callback_factory_.Initialize(this);
   engine_.reset(PDFEngine::Create(this));
   pp::Module::Get()->AddPluginInterface(kPPPPdfInterface, &ppp_private);
   AddPerInstanceObject(kPPPPdfInterface, this);
 
   RequestFilteringInputEvents(PP_INPUTEVENT_CLASS_MOUSE);
   RequestFilteringInputEvents(PP_INPUTEVENT_CLASS_KEYBOARD);
@@ skipping 90 matching lines @@
     return;
   }
 
   std::string type = dict.Get(kType).AsString();
 
   if (type == kJSViewportType &&
       dict.Get(pp::Var(kJSXOffset)).is_int() &&
       dict.Get(pp::Var(kJSYOffset)).is_int() &&
       dict.Get(pp::Var(kJSZoom)).is_number()) {
     received_viewport_message_ = true;
+    stop_scrolling_ = false;
     double zoom = dict.Get(pp::Var(kJSZoom)).AsDouble();
     int x = dict.Get(pp::Var(kJSXOffset)).AsInt();
     int y = dict.Get(pp::Var(kJSYOffset)).AsInt();
 
     // Bound the input parameters.
     zoom = std::max(kMinZoom, zoom);
     int max_x = document_size_.width() * zoom - plugin_dip_size_.width();
     x = std::max(std::min(x, max_x), 0);
     int max_y = document_size_.height() * zoom - plugin_dip_size_.height();
     y = std::max(std::min(y, max_y), 0);
@@ skipping 50 matching lines @@
                       document_load_state_ != LOAD_STATE_LOADING);
       bool has_permissions =
           engine_->HasPermission(PDFEngine::PERMISSION_COPY) ||
           engine_->HasPermission(PDFEngine::PERMISSION_COPY_ACCESSIBLE);
       node.SetBoolean(kAccessibleCopyable, has_permissions);
       std::string json;
       base::JSONWriter::Write(&node, &json);
       reply.Set(pp::Var(kJSAccessibilityJSON), pp::Var(json));
     }
     PostMessage(reply);
+  } else if (type == kJSStopScrollingType) {
+    stop_scrolling_ = true;
   } else {
     NOTREACHED();
   }
 }
 
 bool OutOfProcessInstance::HandleInputEvent(
     const pp::InputEvent& event) {
   // To simplify things, convert the event into device coordinates if it is
   // a mouse event.
   pp::InputEvent event_device_res(event);
@@ skipping 62 matching lines @@
   return (event.GetType() == PP_INPUTEVENT_TYPE_MOUSEDOWN);
 }
 
 void OutOfProcessInstance::DidChangeView(const pp::View& view) {
   pp::Rect view_rect(view.GetRect());
   float old_device_scale = device_scale_;
   float device_scale = view.GetDeviceScale();
   pp::Size view_device_size(view_rect.width() * device_scale,
                             view_rect.height() * device_scale);
 
+  if (!stop_scrolling_) {
+    pp::Point scroll_offset(view.GetScrollOffset());
+    int max_x = document_size_.width() * zoom_ - plugin_dip_size_.width();

[Lei Zhang, 2014/06/23 09:19:41]

Can we share some of the code with line 369?

[raymes, 2014/06/24 00:41:53]

Done.

+    int x = std::max(std::min(scroll_offset.x(), max_x), 0);
+    int max_y = document_size_.height() * zoom_ - plugin_dip_size_.height();
+    int y = std::max(std::min(scroll_offset.y(), max_y), 0);
+    engine_->ScrolledToXPosition(x * device_scale_);
+    engine_->ScrolledToYPosition(y * device_scale_);
+  }
+
   if (view_device_size == plugin_size_ && device_scale == device_scale_)
     return; // We don't care about the position, only the size.
 
   device_scale_ = device_scale;
   plugin_dip_size_ = view_rect.size();
   plugin_size_ = view_device_size;
 
   paint_manager_.SetSize(view_device_size, device_scale_);
 
   pp::Size new_image_data_size = PaintManager::GetNewContextSize(
@@ skipping 878 matching lines @@
   LoadPreviewUrl(url);
 }
 
 void OutOfProcessInstance::UserMetricsRecordAction(
     const std::string& action) {
   // TODO(raymes): Move this function to PPB_UMA_Private.
   pp::PDF::UserMetricsRecordAction(this, pp::Var(action));
 }
 
 }  // namespace chrome_pdf