Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 34773003: force accessor pair accesses backed by simple api calls to be generic accesses when crankshafted (Closed)

Created:
7 years, 2 months ago by dcarney
Modified:
7 years, 2 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

force accessor pair accesses backed by simple api calls to be generic accesses when crankshafted R=mstarzinger@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=17332

Patch Set 1 : #

Total comments: 2

Patch Set 2 : todos #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M src/hydrogen.cc View 1 2 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
dcarney
7 years, 2 months ago (2013-10-22 10:26:13 UTC) #1
Michael Starzinger
LGTM. https://codereview.chromium.org/34773003/diff/40001/src/hydrogen.cc File src/hydrogen.cc (right): https://codereview.chromium.org/34773003/diff/40001/src/hydrogen.cc#newcode4237 src/hydrogen.cc:4237: CallOptimization call_optimization(func); As discussed offline: Can we leave ...
7 years, 2 months ago (2013-10-23 08:40:21 UTC) #2
dcarney
7 years, 2 months ago (2013-10-23 08:46:55 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r17332 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698