Issue 34773002: Adding an api to get number of event listeners.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 34773002: Adding an api to get number of event listeners. (Closed)

Created:
7 years, 2 months ago by siddharthab

Modified:
6 years, 2 months ago

Reviewers:
stgao

CC:
chromium-reviews, frankf

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Adding an api to get number of event listeners. initial phase BUG=

Patch Set 1 #

Patch Set 2 : Adding some more files to the patch set. #

Total comments: 2

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+123 lines, -0 lines)			Patch
A	chrome/test/chromedriver/chrome/event_listener_count.h	View	1	1 chunk	+37 lines, -0 lines	1 comment	Download
A	chrome/test/chromedriver/chrome/event_listener_count.cc	View	1	1 chunk	+66 lines, -0 lines	1 comment	Download
M	chrome/test/chromedriver/chrome/stub_web_view.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/test/chromedriver/chrome/stub_web_view.cc	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/test/chromedriver/chrome/web_view.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/test/chromedriver/chrome/web_view_impl.h	View	1	3 chunks	+3 lines, -0 lines	0 comments	Download
M	chrome/test/chromedriver/chrome/web_view_impl.cc	View	1	3 chunks	+6 lines, -0 lines	0 comments	Download
M	chrome/test/chromedriver/window_commands.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

chrisgao (Use stgao instead)

7 years, 1 month ago (2013-10-26 00:54:01 UTC) #1

Hi Siddharth,

I just gave a quick review to the newly-added event_listener_count.h/cc.

Will take a closer review later when you publish the CL to us.

Thanks,
Shuotao Gao

https://codereview.chromium.org/34773002/diff/60001/chrome/test/chromedriver/...
File chrome/test/chromedriver/chrome/event_listener_count.cc (right):

https://codereview.chromium.org/34773002/diff/60001/chrome/test/chromedriver/...
chrome/test/chromedriver/chrome/event_listener_count.cc:50:
"Memory.getDOMCounters"
It seems no need to enable the debugger.

And I think we can move the code here to WebViewImpl::GetEventListenersCount you
added in web_view_impl.cc

https://codereview.chromium.org/34773002/diff/60001/chrome/test/chromedriver/...
File chrome/test/chromedriver/chrome/event_listener_count.h (right):

https://codereview.chromium.org/34773002/diff/60001/chrome/test/chromedriver/...
chrome/test/chromedriver/chrome/event_listener_count.h:24: class
EventListenerCount: public DevToolsEventListener {
We don't need to inherit DevToolsEventListener here.
Because the OnConnected/OnEvent/OnCommandSuccess are not overridden, and there
is no need to override them.

Expand Messages | Collapse Messages