Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(881)

Issue 347663002: Add a dependency on libelf-dev:i386. (Closed)

Created:
6 years, 6 months ago by Nico
Modified:
6 years, 6 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Add a dependency on libelf-dev:i386. This is needed for https://codereview.chromium.org/341573003/ On Lucid, libelf-dev:i386 couldn't be installed in parallel to the 64bit version. So nacl has a hack to remove -m32 flags from a target that depends on libelf, to make a target_arch=ia32 on a 64bit system with multilibs work. In precise, libelf-dev:i386 can be installed in parallel, so do so as a prerequisite for removing this hack. BUG=368384 R=thestig@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278180

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/install-build-deps.sh View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 6 (0 generated)
Nico
6 years, 6 months ago (2014-06-18 21:07:48 UTC) #1
Lei Zhang
lgtm I took a crack at the nacl hack but never formalized the fix. *shrug* ...
6 years, 6 months ago (2014-06-18 21:23:45 UTC) #2
Nico
Thanks! https://codereview.chromium.org/347663002/diff/1/build/install-build-deps.sh File build/install-build-deps.sh (right): https://codereview.chromium.org/347663002/diff/1/build/install-build-deps.sh#newcode155 build/install-build-deps.sh:155: libexif12:i386 libgl1-mesa-glx:i386 libelf-dev:i386" On 2014/06/18 21:23:45, Lei Zhang ...
6 years, 6 months ago (2014-06-18 21:29:28 UTC) #3
Nico
Committed patchset #1 manually as r278180 (presubmit successful).
6 years, 6 months ago (2014-06-18 21:30:24 UTC) #4
Nico
Oh, what's the best way to get this script re-run on all bots? Email troopers? ...
6 years, 6 months ago (2014-06-18 21:30:45 UTC) #5
Lei Zhang
6 years, 6 months ago (2014-06-18 22:14:58 UTC) #6
Message was sent while issue was closed.
On 2014/06/18 21:30:45, Nico (away) wrote:
> Oh, what's the best way to get this script re-run on all bots? Email troopers?
> File a bug? Ask you?

Ask the troopers. They may tell you to file a bug.

Powered by Google App Engine
This is Rietveld 408576698