Define a single macro for enabling backup function.

Define a single macro for enabling backup function on desktop: win, mac (exclude ios), 
linux (exclude cros).

BUG=362679
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278659

[pvalenzuela1, 2014-06-19 00:15:58]

https://codereview.chromium.org/347653006/diff/1/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/347653006/diff/1/build/common.gypi#newcode682
build/common.gypi:682: ['OS=="win" or OS=="mac" or (OS=="linux" and
chromeos==0)', {
Based on the CL description (and the changes here), it appears this CL
purposefully does not fix the bug (check for iOS as the OS). Is this correct?

IMO we should make the fix as part of this CL.

[haitaol1, 2014-06-19 16:36:31]

https://codereview.chromium.org/347653006/diff/1/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/347653006/diff/1/build/common.gypi#newcode682
build/common.gypi:682: ['OS=="win" or OS=="mac" or (OS=="linux" and
chromeos==0)', {
Because there's only one OS variable, it can't be both mac and ios, so
(OS=="mac" and OS != "ios") is equivalent to OS=="mac". I think mac and ios are
probably mutual exclusive in this file. Can you patch this cl and run ios test
to verify?

On 2014/06/19 00:15:58, pvalenzuela1 wrote:
> Based on the CL description (and the changes here), it appears this CL
> purposefully does not fix the bug (check for iOS as the OS). Is this correct?
> 
> IMO we should make the fix as part of this CL.

[pvalenzuela1, 2014-06-19 18:30:21]

https://codereview.chromium.org/347653006/diff/1/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/347653006/diff/1/build/common.gypi#newcode682
build/common.gypi:682: ['OS=="win" or OS=="mac" or (OS=="linux" and
chromeos==0)', {
On 2014/06/19 16:36:31, haitaol1 wrote:
> Because there's only one OS variable, it can't be both mac and ios, so
> (OS=="mac" and OS != "ios") is equivalent to OS=="mac". I think mac and ios
are
> probably mutual exclusive in this file. Can you patch this cl and run ios test
> to verify?
> 
> On 2014/06/19 00:15:58, pvalenzuela1 wrote:
> > Based on the CL description (and the changes here), it appears this CL
> > purposefully does not fix the bug (check for iOS as the OS). Is this
correct?
> > 
> > IMO we should make the fix as part of this CL.
> 

Ah, you're right. I misread. This should work; you can set up an iOS environment
to confirm.

Please update the CL description to note that this disables the feature on iOS.
It is not clear from the code that it does this.

[pval...(no longer on Chromium), 2014-06-19 18:32:12]

Oops; got my accounts mixed up. Sorry about that.

[Nicolas Zea, 2014-06-19 18:56:53]

LGTM barring Patrick's comment

[pval...(no longer on Chromium), 2014-06-19 21:36:42]

lgtm

It looks like you updated the description. I think it should be <=72 chars per
line, so please fix.

[pval...(no longer on Chromium), 2014-06-19 22:02:23]

FYI I patched the CL in my iOS client and all is well.

[haitaol1, 2014-06-19 22:20:26]

On 2014/06/19 22:02:23, pvalenzuela wrote:
> FYI I patched the CL in my iOS client and all is well.

Thanks.

[haitaol1, 2014-06-19 22:32:40]

The CQ bit was checked by haitaol@chromium.org

[commit-bot: I haz the power, 2014-06-19 22:35:51]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/haitaol@chromium.org/347653006/1

[commit-bot: I haz the power, 2014-06-20 03:04:17]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/8...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-06-20 09:57:09]

Change committed as 278659