content/common/gpu/image_transport_surface_mac.mm - Issue 347653005: Make cross-process CALayers work on Mac

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/image_transport_surface_mac.mm

Issue 347653005: Make cross-process CALayers work on Mac (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@image_transport_1

Patch Set: Incorporate review feedback Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/common/gpu/image_transport_surface_mac.mm

diff --git a/content/common/gpu/image_transport_surface_mac.mm b/content/common/gpu/image_transport_surface_mac.mm

index 9ab22728e07cd2df53fe73437ed41001611ee4b5..3cfda14b93ed13e4045289cd1084064d9cdbdb72 100644

--- a/content/common/gpu/image_transport_surface_mac.mm

+++ b/content/common/gpu/image_transport_surface_mac.mm

@@ -6,6 +6,7 @@

#include "content/common/gpu/gpu_messages.h"

#include "content/common/gpu/image_transport_surface_iosurface_mac.h"

+#include "content/common/gpu/image_transport_surface_calayer_mac.h"

#include "ui/gfx/native_widget_types.h"

#include "ui/gl/gl_context.h"

#include "ui/gl/gl_implementation.h"

@@ -48,6 +49,8 @@ scoped_refptr<gfx::GLSurface> ImageTransportSurface::CreateNativeSurface(

switch (gfx::GetGLImplementation()) {

case gfx::kGLImplementationDesktopGL:

case gfx::kGLImplementationAppleGL:

+ // TODO(ccameron): If the remote layer API is supported on this system,

+ // use a CALayerStorageProvider instead of an IOSurfaceStorageProvider.

return scoped_refptr<gfx::GLSurface>(new ImageTransportSurfaceFBO(

new IOSurfaceStorageProvider, manager, stub, surface_handle.handle));

default: