LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-open-method-allowed.html - Issue 347653003: XMLHttpRequest must build a request using the given method as-is for non-standard types

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-open-method-allowed.html

Issue 347653003: XMLHttpRequest must build a request using the given method as-is for non-standard types (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Write async tests Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/http/tests/xmlhttprequest/resources/request-method.php ('k') | LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-open-method-allowed-expected.txt » ('j') | LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-open-method-case-insensitive.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <title>XMLHttpRequest: open() - allowed case in/sensitive methods test</titl e>

	5 <script src="../resources/testharness.js"></script>

	6 <script src="../resources/testharnessreport.js"></script>

	7 </head>

	8 <body>

	9 <p>Valid methods per step-5 of http://xhr.spec.whatwg.org/#the-open()-method .</p>

	10 <script type="text/javascript">

	11 if (window.testRunner)

	12 window.testRunner.dumpAsText();
	tyoshino (SeeGerritForStatus) 2014/06/20 02:13:34 this is included in testharnessreport.js this is included in testharnessreport.js maheshkk 2014/06/20 04:53:19 Done. Show quoted text On 2014/06/20 02:13:34, tyoshino wrote: > this is included in testharnessreport.js Done.
	13

	14 function testMethod(methodName, lastTest) {
	tyoshino (SeeGerritForStatus) 2014/06/20 02:13:34 lastTest is not used? lastTest is not used? maheshkk 2014/06/20 04:53:19 Done. Had it for async_test usage but got it worki Show quoted text On 2014/06/20 02:13:34, tyoshino wrote: > lastTest is not used? Done. Had it for async_test usage but got it working with test() of testharness.js.
	15 var client = new XMLHttpRequest();

	16 client.open(methodName, "resources/request-method.php");
	tyoshino (SeeGerritForStatus) 2014/06/20 02:13:34 how about naming this echo-request-method.php? how about naming this echo-request-method.php? maheshkk 2014/06/20 04:53:19 Done. Show quoted text On 2014/06/20 02:13:34, tyoshino wrote: > how about naming this echo-request-method.php? Done.
	17 client.onreadystatechange = function(event) {

	18 if (event.target.readyState == 4)

	19 assert_equals(client.getResponseHeader("x-custom-request-method"), m ethodName.toUpperCase());

	20 }

	21 client.send(null);

	22 }

	23

	24 test(function() { testMethod("PUT"); });

	25 test(function() { testMethod("Put"); });

	26 test(function() { testMethod("DELETE"); });

	27 test(function() { testMethod("DeLeTe"); });

	28 test(function() { testMethod("HEAD"); });

	29 test(function() { testMethod("hEAd"); });

	30 test(function() { testMethod("OPTIONS"); });

	31 test(function() { testMethod("OPtiOns"); });

	32 test(function() { testMethod("POST"); });

	33 test(function() { testMethod("post"); });

	34 test(function() { testMethod("GET"); });

	35 test(function() { testMethod("gEt", true); });

	36 </script>

	37 </body>

	38 </html>

	39

OLD	NEW