LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-open-method-allowed.html - Issue 347653003: XMLHttpRequest must build a request using the given method as-is for non-standard types

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-open-method-allowed.html

Issue 347653003: XMLHttpRequest must build a request using the given method as-is for non-standard types (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/http/tests/xmlhttprequest/resources/request-method.php ('k') | LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-open-method-allowed-expected.txt » ('j') | LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-open-method-case-insensitive.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <title>XMLHttpRequest: open() - allowed case in/sensitive methods test</titl e>

	5 </head>

	6 <body>

	7 <p>Valid methods per step-5 of http://xhr.spec.whatwg.org/#the-open()-method .</p>

	8 <div id="log"></div>

	9 <script type="text/javascript">

	10 if (window.testRunner)
	sof 2014/06/19 06:19:50 I would have preferred if this (new) test used js- I would have preferred if this (new) test used js-test.js (or testharness.js) maheshkk 2014/06/19 19:33:53 Done. However dumpAsText is still required though! Show quoted text On 2014/06/19 06:19:50, sof wrote: > I would have preferred if this (new) test used js-test.js (or testharness.js) Done. However dumpAsText is still required though!
	11 window.testRunner.dumpAsText();

	12

	13 function log(message) {

	14 document.getElementById("log").appendChild(document.createTextNode(mes sage));

	15 document.getElementById("log").appendChild(document.createElement("br" ));

	16 }

	17 function method(method) {
	sof 2014/06/19 06:19:50 How about 'verb' (or methodName) as the argument n How about 'verb' (or methodName) as the argument name? maheshkk 2014/06/19 19:33:52 Ok sure. This code is mostly used as is per w3c-te Show quoted text On 2014/06/19 06:19:50, sof wrote: > How about 'verb' (or methodName) as the argument name? Ok sure. This code is mostly used as is per w3c-test suite from http://w3c-test.org/XMLHttpRequest/open-method-case-sensitive.htm.
	18 var client = new XMLHttpRequest();

	19 client.open(method, "resources/request-method.php", false);
	sof 2014/06/19 06:19:49 You could run into test timeout problems here, syn You could run into test timeout problems here, sync XHR is slow and flaky on our trybots (esp on Windows.) Please keep an eye out for flakiness (and if so, I think you need to split this test up a bit.) maheshkk 2014/06/19 19:33:52 Done. Show quoted text On 2014/06/19 06:19:49, sof wrote: > You could run into test timeout problems here, sync XHR is slow and flaky on our > trybots (esp on Windows.) Please keep an eye out for flakiness (and if so, I > think you need to split this test up a bit.) Done.
	20 client.send(null);

	21 log(client.getResponseHeader("x-custom-request-method"));

	22 }

	23

	24 method("PUT")
	sof 2014/06/19 06:19:50 Add semicolons to these calls. Add semicolons to these calls. maheshkk 2014/06/19 19:33:52 Done. Show quoted text On 2014/06/19 06:19:50, sof wrote: > Add semicolons to these calls. Done.
	25 method("Put")

	26 method("DELETE")

	27 method("DeLeTe")

	28 method("HEAD")

	29 method("hEAd")

	30 method("OPTIONS")

	31 method("OPtiOns")

	32 method("POST")

	33 method("post")

	34 method("GET")

	35 method("gEt")

	36 </script>

	37 </body>

	38 </html>

	39

OLD	NEW