Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3546)

Unified Diff: chrome/browser/password_manager/password_store_x_unittest.cc

Issue 347583004: PasswordStore refactoring. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/password_store_x_unittest.cc
diff --git a/chrome/browser/password_manager/password_store_x_unittest.cc b/chrome/browser/password_manager/password_store_x_unittest.cc
index 4a67b5d05aafef7320ce33e64cb28bc2c855208c..ac1742630ee6ce67ac5fee1077ebe47fbf210580 100644
--- a/chrome/browser/password_manager/password_store_x_unittest.cc
+++ b/chrome/browser/password_manager/password_store_x_unittest.cc
@@ -68,8 +68,10 @@ class FailingBackend : public PasswordStoreX::NativeBackend {
}
virtual bool RemoveLogin(const PasswordForm& form) OVERRIDE { return false; }
- virtual bool RemoveLoginsCreatedBetween(base::Time delete_begin,
- base::Time delete_end) OVERRIDE {
+ virtual bool RemoveLoginsCreatedBetween(
+ base::Time delete_begin,
+ base::Time delete_end,
+ password_manager::PasswordStoreChangeList* changes) OVERRIDE {
return false;
}
@@ -85,12 +87,6 @@ class FailingBackend : public PasswordStoreX::NativeBackend {
return false;
}
- virtual bool GetLoginsCreatedBetween(base::Time get_begin,
- base::Time get_end,
- PasswordFormList* forms) OVERRIDE {
- return false;
- }
-
virtual bool GetAutofillableLogins(PasswordFormList* forms) OVERRIDE {
return false;
}
@@ -127,8 +123,10 @@ class MockBackend : public PasswordStoreX::NativeBackend {
return true;
}
- virtual bool RemoveLoginsCreatedBetween(base::Time delete_begin,
- base::Time delete_end) OVERRIDE {
+ virtual bool RemoveLoginsCreatedBetween(
+ base::Time delete_begin,
+ base::Time delete_end,
+ password_manager::PasswordStoreChangeList* changes) OVERRIDE {
for (size_t i = 0; i < all_forms_.size(); ++i) {
if (delete_begin <= all_forms_[i].date_created &&
(delete_end.is_null() || all_forms_[i].date_created < delete_end))
@@ -161,16 +159,6 @@ class MockBackend : public PasswordStoreX::NativeBackend {
return true;
}
- virtual bool GetLoginsCreatedBetween(base::Time get_begin,
- base::Time get_end,
- PasswordFormList* forms) OVERRIDE {
- for (size_t i = 0; i < all_forms_.size(); ++i)
- if (get_begin <= all_forms_[i].date_created &&
- (get_end.is_null() || all_forms_[i].date_created < get_end))
- forms->push_back(new PasswordForm(all_forms_[i]));
- return true;
- }
-
virtual bool GetAutofillableLogins(PasswordFormList* forms) OVERRIDE {
for (size_t i = 0; i < all_forms_.size(); ++i)
if (!all_forms_[i].blacklisted_by_user)
« no previous file with comments | « chrome/browser/password_manager/password_store_x.cc ('k') | components/password_manager/core/browser/login_database.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698