Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: chrome/browser/password_manager/password_store_x.h

Issue 347583004: PasswordStore refactoring. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/password_store_x.h
diff --git a/chrome/browser/password_manager/password_store_x.h b/chrome/browser/password_manager/password_store_x.h
index edc2c4e9f302efc10708aa97db4cf5ab81036e8a..53b47f934acfa5ed475fd12dd963b361da9cb595 100644
--- a/chrome/browser/password_manager/password_store_x.h
+++ b/chrome/browser/password_manager/password_store_x.h
@@ -50,8 +50,10 @@ class PasswordStoreX : public password_manager::PasswordStoreDefault {
// Removes all logins created/synced from |delete_begin| onwards (inclusive)
// and before |delete_end|. You may use a null Time value to do an unbounded
// delete in either direction.
- virtual bool RemoveLoginsCreatedBetween(base::Time delete_begin,
- base::Time delete_end) = 0;
+ virtual bool RemoveLoginsCreatedBetween(
+ base::Time delete_begin,
+ base::Time delete_end,
+ password_manager::PasswordStoreChangeList* changes) = 0;
virtual bool RemoveLoginsSyncedBetween(
base::Time delete_begin,
base::Time delete_end,
@@ -59,9 +61,6 @@ class PasswordStoreX : public password_manager::PasswordStoreDefault {
virtual bool GetLogins(const autofill::PasswordForm& form,
PasswordFormList* forms) = 0;
- virtual bool GetLoginsCreatedBetween(base::Time get_begin,
- base::Time get_end,
- PasswordFormList* forms) = 0;
virtual bool GetAutofillableLogins(PasswordFormList* forms) = 0;
virtual bool GetBlacklistLogins(PasswordFormList* forms) = 0;
};
@@ -86,8 +85,8 @@ class PasswordStoreX : public password_manager::PasswordStoreDefault {
virtual password_manager::PasswordStoreChangeList RemoveLoginImpl(
const autofill::PasswordForm& form) OVERRIDE;
virtual password_manager::PasswordStoreChangeList
- RemoveLoginsCreatedBetweenImpl(const base::Time& delete_begin,
- const base::Time& delete_end) OVERRIDE;
+ RemoveLoginsCreatedBetweenImpl(base::Time delete_begin,
+ base::Time delete_end) OVERRIDE;
virtual password_manager::PasswordStoreChangeList
RemoveLoginsSyncedBetweenImpl(base::Time delete_begin,
base::Time delete_end) OVERRIDE;
« no previous file with comments | « chrome/browser/password_manager/password_store_mac.cc ('k') | chrome/browser/password_manager/password_store_x.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698