content/browser/renderer_host/websocket_dispatcher_host.cc - Issue 34753008: Notify WebSocket connection failure, chromium side

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/websocket_dispatcher_host.cc

Issue 34753008: Notify WebSocket connection failure, chromium side (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/websocket_dispatcher_host.cc

diff --git a/content/browser/renderer_host/websocket_dispatcher_host.cc b/content/browser/renderer_host/websocket_dispatcher_host.cc

index 902664e909762ebd96dff94cb909cf0802ffd916..e6e66ed51b4f80fbf39f151463f3382f3d3b86af 100644

--- a/content/browser/renderer_host/websocket_dispatcher_host.cc

+++ b/content/browser/renderer_host/websocket_dispatcher_host.cc

@@ -110,7 +110,9 @@ void WebSocketDispatcherHost::SendClosing(int routing_id) {

void WebSocketDispatcherHost::DoDropChannel(int routing_id,

uint16 code,

const std::string& reason) {

- SendOrDrop(new WebSocketMsg_DropChannel(routing_id, code, reason));

+ // TODO(yhirano): Set |was_clean| appropriately.

+ bool was_clean = true;

+ SendOrDrop(new WebSocketMsg_DropChannel(routing_id, was_clean, code, reason));

DeleteWebSocketHost(routing_id);

}