Notify WebSocket connection failure, chromium side

content/common/websocket_messages.h

Index: content/common/websocket_messages.h
diff --git a/content/common/websocket_messages.h b/content/common/websocket_messages.h
index 5a9304f8a700888fcfc2b5c7b72fdf566ac5341e..0ac63cc6adcc05fe3e7072cc671c64c53bab1dbb 100644
--- a/content/common/websocket_messages.h
+++ b/content/common/websocket_messages.h
@@ -43,7 +43,7 @@ IPC_MESSAGE_ROUTED3(WebSocketHostMsg_AddChannelRequest,
                     std::vector<std::string> /* requested_protocols */,
                     GURL /* origin */)
 
-// Web Socket messages sent from the browser to the renderer.
+// WebSocket messages sent from the browser to the renderer.
 
 // Respond to an AddChannelRequest for channel |channel_id|. |channel_id| is
 // scoped to the renderer process; while it is unique per-renderer, the browser
@@ -59,6 +59,15 @@ IPC_MESSAGE_ROUTED3(WebSocketMsg_AddChannelResponse,
                     std::string /* selected_protocol */,
                     std::string /* extensions */)
 
+// Notify the renderer that the browser is required to fail the connection.
+// This message will be followed by a corresponding DropChannel message and
+// hence the renderer should NOT drop the channel when it receives this
+// message.
+// |message| will be shown in the inspector and won't be passed to the

[Adam Rice, 2013/10/23 07:15:30]

If we had a way to pass the message directly to the process running the
inspector it would be preferable. But then I suppose we'd lose file & line
information.

Could you put in a TODO for "Find a way to not expose this information to the
renderer process"? Then we can worry about it when we are less busy.

[yhirano, 2013/10/23 08:10:42]

Done.

+// script.
+IPC_MESSAGE_ROUTED1(WebSocketMsg_NotifyFailure,
+                    std::string /* message */)
+
 // WebSocket messages that can be sent in either direction.
 
 IPC_ENUM_TRAITS(content::WebSocketMessageType)
@@ -100,6 +109,12 @@ IPC_MESSAGE_ROUTED1(WebSocketMsg_FlowControl,
 // UTF-8 encoded string which may be useful for debugging but is not necessarily
 // human-readable, as supplied by the server in the Close or DropChannel
 // message.
-IPC_MESSAGE_ROUTED2(WebSocketMsg_DropChannel,
+// If |was_clean| is false on a message from the browser, then the WebSocket
+// connection was not closed cleanly. If |was_clean| is false on a message from
+// the renderer, then the connection should be closed immediately without a
+// closing handshake and the renderer cannot accept any new messages about this
+// connection.
+IPC_MESSAGE_ROUTED3(WebSocketMsg_DropChannel,
+                    bool /* was_clean */,
                     unsigned short /* code */,
                     std::string /* reason */)