content/common/websocket_messages.h - Issue 34753008: Notify WebSocket connection failure, chromium side

Side by Side Diff: content/common/websocket_messages.h

Issue 34753008: Notify WebSocket connection failure, chromium side (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/browser/renderer_host/websocket_host.cc ('K') | « content/child/websocket_bridge.cc ('k') | net/websockets/websocket_channel.cc » ('j') | net/websockets/websocket_channel.cc » ('J')

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // Multiply-included message file, hence no include guard.	5 // Multiply-included message file, hence no include guard.

6	6

7 // This file defines the IPCs for the browser-side implementation of	7 // This file defines the IPCs for the browser-side implementation of

8 // WebSockets. For the legacy renderer-side implementation, see	8 // WebSockets. For the legacy renderer-side implementation, see

9 // socket_stream_messages.h.	9 // socket_stream_messages.h.

10 // TODO(ricea): Fix this comment when the legacy implementation has been	10 // TODO(ricea): Fix this comment when the legacy implementation has been

(...skipping 82 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
93 // and the TCP/IP connection will be closed.	93 // and the TCP/IP connection will be closed.

94 // When sent by the browser, this indicates that a Close or DropChannel has been	94 // When sent by the browser, this indicates that a Close or DropChannel has been

95 // received, the connection was closed, or a network or protocol error	95 // received, the connection was closed, or a network or protocol error

96 // occurred. On receiving DropChannel, the renderer process may consider the	96 // occurred. On receiving DropChannel, the renderer process may consider the

97 // \|channel_id\| available for reuse by a new AddChannelRequest.	97 // \|channel_id\| available for reuse by a new AddChannelRequest.

98 // \|code\| is one of the reason codes specified in RFC6455 or	98 // \|code\| is one of the reason codes specified in RFC6455 or

99 // draft-ietf-hybi-websocket-multiplexing-09. \|reason\|, if non-empty, is a	99 // draft-ietf-hybi-websocket-multiplexing-09. \|reason\|, if non-empty, is a

100 // UTF-8 encoded string which may be useful for debugging but is not necessarily	100 // UTF-8 encoded string which may be useful for debugging but is not necessarily

101 // human-readable, as supplied by the server in the Close or DropChannel	101 // human-readable, as supplied by the server in the Close or DropChannel

102 // message.	102 // message.

103 IPC_MESSAGE_ROUTED2(WebSocketMsg_DropChannel,	103 // \|fail\| is true when the user agent is required to fail the connection.
	Adam Rice 2013/10/23 03:18:06 I think this comment needs more explanation. How a I think this comment needs more explanation. How about: If \|fail\| is true on a message from the browser, then the WebSocket connection was not closed cleanly. If \|fail\| is true on a message from the renderer, then the connection should be closed immediately without a closing handshake and the renderer cannot accept any new messages about this connection. yhirano 2013/10/23 05:42:23 Thanks, done. Show quoted text On 2013/10/23 03:18:06, Adam Rice wrote: > I think this comment needs more explanation. How about: > > If \|fail\| is true on a message from the browser, then the WebSocket connection > was not closed cleanly. If \|fail\| is true on a message from the renderer, then > the connection should be closed immediately without a closing handshake and the > renderer cannot accept any new messages about this connection. Thanks, done.
	104 IPC_MESSAGE_ROUTED3(WebSocketMsg_DropChannel,

	105 bool /* fail */,

104 unsigned short /* code */,	106 unsigned short /* code */,

105 std::string /* reason */)	107 std::string /* reason */)

OLD	NEW