Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Side by Side Diff: src/x64/full-codegen-x64.cc

Issue 34753004: Make macro-assembler-x64 deal with handles to objects in new space by default. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/x64/lithium-codegen-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1111 matching lines...) Expand 10 before | Expand all | Expand 10 after
1122 __ jmp(&exit); 1122 __ jmp(&exit);
1123 1123
1124 // We got a fixed array in register rax. Iterate through that. 1124 // We got a fixed array in register rax. Iterate through that.
1125 Label non_proxy; 1125 Label non_proxy;
1126 __ bind(&fixed_array); 1126 __ bind(&fixed_array);
1127 1127
1128 Handle<Cell> cell = isolate()->factory()->NewCell( 1128 Handle<Cell> cell = isolate()->factory()->NewCell(
1129 Handle<Object>(Smi::FromInt(TypeFeedbackCells::kForInFastCaseMarker), 1129 Handle<Object>(Smi::FromInt(TypeFeedbackCells::kForInFastCaseMarker),
1130 isolate())); 1130 isolate()));
1131 RecordTypeFeedbackCell(stmt->ForInFeedbackId(), cell); 1131 RecordTypeFeedbackCell(stmt->ForInFeedbackId(), cell);
1132 __ LoadHeapObject(rbx, cell); 1132 __ Move(rbx, cell);
1133 __ Move(FieldOperand(rbx, Cell::kValueOffset), 1133 __ Move(FieldOperand(rbx, Cell::kValueOffset),
1134 Smi::FromInt(TypeFeedbackCells::kForInSlowCaseMarker)); 1134 Smi::FromInt(TypeFeedbackCells::kForInSlowCaseMarker));
1135 1135
1136 __ Move(rbx, Smi::FromInt(1)); // Smi indicates slow check 1136 __ Move(rbx, Smi::FromInt(1)); // Smi indicates slow check
1137 __ movq(rcx, Operand(rsp, 0 * kPointerSize)); // Get enumerated object 1137 __ movq(rcx, Operand(rsp, 0 * kPointerSize)); // Get enumerated object
1138 STATIC_ASSERT(FIRST_JS_PROXY_TYPE == FIRST_SPEC_OBJECT_TYPE); 1138 STATIC_ASSERT(FIRST_JS_PROXY_TYPE == FIRST_SPEC_OBJECT_TYPE);
1139 __ CmpObjectType(rcx, LAST_JS_PROXY_TYPE, rcx); 1139 __ CmpObjectType(rcx, LAST_JS_PROXY_TYPE, rcx);
1140 __ j(above, &non_proxy); 1140 __ j(above, &non_proxy);
1141 __ Move(rbx, Smi::FromInt(0)); // Zero indicates proxy 1141 __ Move(rbx, Smi::FromInt(0)); // Zero indicates proxy
1142 __ bind(&non_proxy); 1142 __ bind(&non_proxy);
(...skipping 3804 matching lines...) Expand 10 before | Expand all | Expand 10 after
4947 4947
4948 ASSERT_EQ(isolate->builtins()->OsrAfterStackCheck()->entry(), 4948 ASSERT_EQ(isolate->builtins()->OsrAfterStackCheck()->entry(),
4949 Assembler::target_address_at(call_target_address)); 4949 Assembler::target_address_at(call_target_address));
4950 return OSR_AFTER_STACK_CHECK; 4950 return OSR_AFTER_STACK_CHECK;
4951 } 4951 }
4952 4952
4953 4953
4954 } } // namespace v8::internal 4954 } } // namespace v8::internal
4955 4955
4956 #endif // V8_TARGET_ARCH_X64 4956 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « no previous file | src/x64/lithium-codegen-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698