Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1868)

Issue 347523002: Fix LStoreCodeEntry to treat the code_object parameter as input. (Closed)

Created:
6 years, 6 months ago by Jarin
Modified:
6 years, 6 months ago
Reviewers:
mvstanton
CC:
v8-dev
Visibility:
Public.

Description

Fix LStoreCodeEntry to treat the code_object parameter as input. The bug seems to trigger only with array_index_dehoisting off in the snapshot, so it is hard to test for (ideas?). R=mvstanton@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=21885

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M src/arm/lithium-arm.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/ia32/lithium-ia32.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/mips/lithium-mips.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/x64/lithium-x64.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/x87/lithium-x87.h View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jarin
6 years, 6 months ago (2014-06-18 09:40:07 UTC) #1
mvstanton
Thank you for finding my bug :). LGTM.
6 years, 6 months ago (2014-06-18 10:41:14 UTC) #2
Jarin
6 years, 6 months ago (2014-06-18 11:18:01 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21885 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698