Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 347513003: Adding iOS support for image_store. (Closed)

Created:
6 years, 6 months ago by noyau (Ping after 24h)
Modified:
6 years, 6 months ago
CC:
chromium-reviews, sky
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+224 lines, -13 lines) Patch
M components/components_tests.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M components/enhanced_bookmarks.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A components/enhanced_bookmarks/image_store_ios_unittest.mm View 1 chunk +153 lines, -0 lines 0 comments Download
M components/enhanced_bookmarks/image_store_unittest.cc View 3 chunks +18 lines, -13 lines 0 comments Download
A components/enhanced_bookmarks/image_store_util_ios.mm View 1 chunk +50 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
noyau (Ping after 24h)
6 years, 6 months ago (2014-06-18 11:35:22 UTC) #1
Kibeom Kim (inactive)
lgtm
6 years, 6 months ago (2014-06-18 18:18:29 UTC) #2
noyau (Ping after 24h)
To sky for owner review.
6 years, 6 months ago (2014-06-18 19:38:59 UTC) #3
sky
What files do you need me to review here? You are an owner in enhanced_bookmarks, ...
6 years, 6 months ago (2014-06-19 15:00:03 UTC) #4
noyau (Ping after 24h)
On 2014/06/19 15:00:03, sky wrote: > What files do you need me to review here? ...
6 years, 6 months ago (2014-06-19 15:08:43 UTC) #5
noyau (Ping after 24h)
- sky@ + blundell@ for gyp file changes (TBR)
6 years, 6 months ago (2014-06-19 15:12:41 UTC) #6
noyau (Ping after 24h)
The CQ bit was checked by noyau@chromium.org
6 years, 6 months ago (2014-06-19 15:12:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noyau@chromium.org/347513003/1
6 years, 6 months ago (2014-06-19 15:14:28 UTC) #8
blundell
lgtm
6 years, 6 months ago (2014-06-19 15:34:55 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 21:07:07 UTC) #10
Message was sent while issue was closed.
Change committed as 278482

Powered by Google App Engine
This is Rietveld 408576698