Chromium Code Reviews
Help | Chromium Project | Sign in
(450)

Issue 3475013: test server for safebrowsing test (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 6 months ago by lzheng
Modified:
2 years, 11 months ago
Reviewers:
nsylvain
CC:
chromium-reviews_chromium.org
Visibility:
Public.

Description

Add safebrowsing test server into dependencies. Also added Readme.chromium for third party code inclusion and safe_browsing.gyp to specified the dependency between this test and proto buffer.

TEST=none
BUG=47318
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60810

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : 'rebase' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -0 lines) Lint Patch
M DEPS View 1 2 3 1 chunk +3 lines, -0 lines 0 comments 0 errors Download
M chrome/chrome_tests.gypi View 1 2 3 1 chunk +2 lines, -0 lines 0 comments 0 errors Download
A third_party/safe_browsing/README.chromium View 1 chunk +8 lines, -0 lines 0 comments 0 errors Download
A third_party/safe_browsing/safe_browsing.gyp View 1 1 chunk +29 lines, -0 lines 0 comments 0 errors Download
Commit:

Messages

Total messages: 8
lzheng
3 years, 6 months ago #1
nsylvain
http://codereview.chromium.org/3475013/diff/1/2 File DEPS (right): http://codereview.chromium.org/3475013/diff/1/2#newcode53 DEPS:53: (Var("googlecode_url") % "google-safe-browsing") + "/trunk/testing@99", Please use the full ...
3 years, 6 months ago #2
lzheng1
On Thu, Sep 23, 2010 at 4:48 PM, <nsylvain@google.com> wrote: > > http://codereview.chromium.org/3475013/diff/1/2 > File ...
3 years, 6 months ago #3
nsylvain
On Thu, Sep 23, 2010 at 5:16 PM, Lei Zheng <lzheng@google.com> wrote: > > > ...
3 years, 6 months ago #4
lzheng1
Thanks for the info. Done with the changes. Another look? Thanks! Lei On Thu, Sep ...
3 years, 6 months ago #5
nsylvain
i think I forgot to reply to this review. sorry. LGTM
3 years, 6 months ago #6
lzheng1
Nicolas: Change submitted. Thanks for the review. Are you planning to restart bot masters so ...
3 years, 6 months ago #7
nsylvain
3 years, 6 months ago #8
On Tue, Sep 28, 2010 at 1:14 PM, Lei Zheng <lzheng@google.com> wrote:

> Nicolas:
>
> Change submitted. Thanks for the review.
>
> Are you planning to restart bot masters so the safe_browsing_tests could be
> running anytime soon?
>

 I actually just restarted it this morning, so it missed the cut. I'll try
to do it again later this week or this weekend.

Nicolas


> Lei
>
>
> On Sun, Sep 26, 2010 at 11:24 AM, <nsylvain@google.com> wrote:
>
>> i think I forgot to reply to this review. sorry.
>>
>> LGTM
>>
>>
>> http://codereview.chromium.org/3475013/show
>>
>
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6