test server for safebrowsing test

Add safebrowsing test server into dependencies. Also added Readme.chromium for third party code inclusion and safe_browsing.gyp to specified the dependency between this test and proto buffer.

TEST=none
BUG=47318
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60810

[nsylvain, 2010-09-23 23:48:40]

http://codereview.chromium.org/3475013/diff/1/2
File DEPS (right):

http://codereview.chromium.org/3475013/diff/1/2#newcode53
DEPS:53: (Var("googlecode_url") % "google-safe-browsing") + "/trunk/testing@99",
Please use the full path, otherwise this is going to fail.  We don't mirror this
repo yet.

http://codereview.chromium.org/3475013/diff/1/5
File third_party/safe_browsing/safe_browsing.gyp (right):

http://codereview.chromium.org/3475013/diff/1/5#newcode1
third_party/safe_browsing/safe_browsing.gyp:1: # Copyright (c) 2009 The Chromium
Authors. All rights reserved.
2010?

[lzheng1, 2010-09-24 00:16:23]

On Thu, Sep 23, 2010 at 4:48 PM, <nsylvain@google.com> wrote:

>
> http://codereview.chromium.org/3475013/diff/1/2
> File DEPS (right):
>
> http://codereview.chromium.org/3475013/diff/1/2#newcode53
> DEPS:53: (Var("googlecode_url") % "google-safe-browsing") +
> "/trunk/testing@99",
> Please use the full path, otherwise this is going to fail.  We don't
> mirror this repo yet.
>
Maybe I missed something. Won't this generate *http*://
google-safe-browsing.googlecode.com/svn/trunk? The code is in googlecode.com,
looks like I can get the source code this way.


>
> http://codereview.chromium.org/3475013/diff/1/5
> File third_party/safe_browsing/safe_browsing.gyp (right):
>
> http://codereview.chromium.org/3475013/diff/1/5#newcode1
> third_party/safe_browsing/safe_browsing.gyp:1: # Copyright (c) 2009 The
>
> Chromium Authors. All rights reserved.
> 2010?
>
>
> http://codereview.chromium.org/3475013/show
>

[nsylvain, 2010-09-24 00:56:17]

On Thu, Sep 23, 2010 at 5:16 PM, Lei Zheng <lzheng@google.com> wrote:

>
>
> On Thu, Sep 23, 2010 at 4:48 PM, <nsylvain@google.com> wrote:
>
>>
>> http://codereview.chromium.org/3475013/diff/1/2
>> File DEPS (right):
>>
>> http://codereview.chromium.org/3475013/diff/1/2#newcode53
>> DEPS:53: (Var("googlecode_url") % "google-safe-browsing") +
>> "/trunk/testing@99",
>> Please use the full path, otherwise this is going to fail.  We don't
>> mirror this repo yet.
>>
> Maybe I missed something. Won't this generate *http*://
> google-safe-browsing.googlecode.com/svn/trunk? The code is in
> googlecode.com, looks like I can get the source code this way.
>
Well, this is a var, and it get overwritten at a few places. On the buildbot
this will actually generate something like
svn://private_server/mirror/google-safe-browsing.  Which does not exist
yet.

Nicolas


>
>
>>
>> http://codereview.chromium.org/3475013/diff/1/5
>> File third_party/safe_browsing/safe_browsing.gyp (right):
>>
>> http://codereview.chromium.org/3475013/diff/1/5#newcode1
>> third_party/safe_browsing/safe_browsing.gyp:1: # Copyright (c) 2009 The
>>
>> Chromium Authors. All rights reserved.
>> 2010?
>>
>>
>> http://codereview.chromium.org/3475013/show
>>
>
>

[lzheng1, 2010-09-24 16:24:51]

Thanks for the info. Done with the changes. Another look?

Thanks!

Lei

On Thu, Sep 23, 2010 at 5:55 PM, Nicolas Sylvain <nsylvain@google.com>wrote:

>
>
> On Thu, Sep 23, 2010 at 5:16 PM, Lei Zheng <lzheng@google.com> wrote:
>
>>
>>
>> On Thu, Sep 23, 2010 at 4:48 PM, <nsylvain@google.com> wrote:
>>
>>>
>>> http://codereview.chromium.org/3475013/diff/1/2
>>> File DEPS (right):
>>>
>>> http://codereview.chromium.org/3475013/diff/1/2#newcode53
>>> DEPS:53: (Var("googlecode_url") % "google-safe-browsing") +
>>> "/trunk/testing@99",
>>> Please use the full path, otherwise this is going to fail.  We don't
>>> mirror this repo yet.
>>>
>> Maybe I missed something. Won't this generate *http*://
>> google-safe-browsing.googlecode.com/svn/trunk? The code is in
>> googlecode.com, looks like I can get the source code this way.
>>
> Well, this is a var, and it get overwritten at a few places. On the
> buildbot this will actually generate something like
> svn://private_server/mirror/google-safe-browsing.  Which does not exist
> yet.
>
> Nicolas
>
>
>>
>>
>>>
>>> http://codereview.chromium.org/3475013/diff/1/5
>>> File third_party/safe_browsing/safe_browsing.gyp (right):
>>>
>>> http://codereview.chromium.org/3475013/diff/1/5#newcode1
>>> third_party/safe_browsing/safe_browsing.gyp:1: # Copyright (c) 2009 The
>>>
>>> Chromium Authors. All rights reserved.
>>> 2010?
>>>
>>>
>>> http://codereview.chromium.org/3475013/show
>>>
>>
>>
>

[nsylvain, 2010-09-26 18:24:12]

i think I forgot to reply to this review. sorry.

LGTM

[lzheng1, 2010-09-28 20:14:19]

Nicolas:

Change submitted. Thanks for the review.

Are you planning to restart bot masters so the safe_browsing_tests could be
running anytime soon?

Lei

On Sun, Sep 26, 2010 at 11:24 AM, <nsylvain@google.com> wrote:

> i think I forgot to reply to this review. sorry.
>
> LGTM
>
>
> http://codereview.chromium.org/3475013/show
>

[nsylvain, 2010-09-28 21:04:34]

On Tue, Sep 28, 2010 at 1:14 PM, Lei Zheng <lzheng@google.com> wrote:

> Nicolas:
>
> Change submitted. Thanks for the review.
>
> Are you planning to restart bot masters so the safe_browsing_tests could be
> running anytime soon?
>

 I actually just restarted it this morning, so it missed the cut. I'll try
to do it again later this week or this weekend.

Nicolas


> Lei
>
>
> On Sun, Sep 26, 2010 at 11:24 AM, <nsylvain@google.com> wrote:
>
>> i think I forgot to reply to this review. sorry.
>>
>> LGTM
>>
>>
>> http://codereview.chromium.org/3475013/show
>>
>
>