Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 347493002: Revert 277964 "cc: In SyncFromActiveLayer, drop all tiles not in..." (Closed)

Created:
6 years, 6 months ago by perkj_chrome
Modified:
6 years, 6 months ago
Reviewers:
danakj
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 277964 "cc: In SyncFromActiveLayer, drop all tiles not in..." This cl seems to cause heap use after free on the Asan bots. LargePage FindLongString http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/3837/steps/browser_tests/logs/LargePage http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%283%29/builds/4211/steps/browser_tests/logs/FindLongString > cc: In SyncFromActiveLayer, drop all tiles not in the recorded_viewport. > > Currently we do a walk over all tiles in the pending tree's pile, but > there can be 1 million x 1 million tiles on some pages, which makes this > method take multiple _seconds_ to complete. > > These loops were added in r184525 which gave the tradeoffs that led to > them, which are that we want to only use a single pile for all the tiles > on this layer, but we don't want raster tiles on the active layer (when > this activates) that can't be rastered by the pile they are attached to. > > Instead of walking every pile-tile, to find the tiles that are not > present in the current recording and invalidate them, we expand > invalidations outside the interest rect to cover the full recording tiles, > and we expand invalidation inside the interest rect to include any raster > tiles that don't have a recording (such as in the offscreen animating gif > case). We give this expanded invalidation to the pending layer, causing > it to drop rastered tiles from the active tree that intersect with an > unrecorded area. > > R=enne > BUG=371839 > > Review URL: https://codereview.chromium.org/294163009 TBR=danakj@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277980

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -244 lines) Patch
M trunk/src/cc/base/tiling_data.h View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/cc/base/tiling_data.cc View 1 chunk +6 lines, -18 lines 0 comments Download
M trunk/src/cc/base/tiling_data_unittest.cc View 1 chunk +0 lines, -60 lines 0 comments Download
M trunk/src/cc/layers/picture_layer.cc View 1 chunk +9 lines, -15 lines 0 comments Download
M trunk/src/cc/layers/picture_layer_impl.cc View 2 chunks +17 lines, -1 line 0 comments Download
M trunk/src/cc/resources/picture_pile.h View 1 chunk +10 lines, -13 lines 0 comments Download
M trunk/src/cc/resources/picture_pile.cc View 4 chunks +18 lines, -41 lines 0 comments Download
M trunk/src/cc/resources/picture_pile_base.h View 2 chunks +1 line, -5 lines 0 comments Download
M trunk/src/cc/resources/picture_pile_unittest.cc View 9 chunks +35 lines, -89 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
perkj_chrome
6 years, 6 months ago (2014-06-18 08:18:19 UTC) #1
perkj_chrome
6 years, 6 months ago (2014-06-18 08:20:33 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r277980 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698