Issue 347463006: DevTools: Crash fix.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 347463006: DevTools: Crash fix. (Closed)

Created:
6 years, 6 months ago by aandrey

Modified:
6 years, 6 months ago

Reviewers:
yurys

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

DevTools: Crash fix. BUG=384556 R=yurys Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176418

Patch Set 1 #

Total comments: 1

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	Source/core/inspector/InjectedScript.cpp	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

aandrey

https://codereview.chromium.org/347463006/diff/1/Source/core/inspector/InjectedScript.cpp File Source/core/inspector/InjectedScript.cpp (right): https://codereview.chromium.org/347463006/diff/1/Source/core/inspector/InjectedScript.cpp#newcode245 Source/core/inspector/InjectedScript.cpp:245: if (result && result->type() == JSONValue::TypeArray) Looks like this ...

6 years, 6 months ago (2014-06-18 10:41:55 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/347463006/1

6 years, 6 months ago (2014-06-18 11:47:34 UTC) #5

Message was sent while issue was closed.

Change committed as 176418

Expand Messages | Collapse Messages