Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 347443002: Add nanobench, a fresh look at our microbenchmark harness. (Closed)

Created:
6 years, 6 months ago by mtklein_C
Modified:
6 years, 6 months ago
Reviewers:
djsollen, mtklein
CC:
reviews_skia.org, borenet, tfarina
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Add nanobench, a fresh look at our microbenchmark harness. out/Release/nanobench runs 4-5x faster on my Z620 and ~2x faster on my N5 than out/Release/bench with the same configs. (Debug isn't really comparable. I haven't added the Debug -> single loop check.) BUG=skia:

Patch Set 1 #

Patch Set 2 : configs #

Patch Set 3 : gpu #

Patch Set 4 : tweaks #

Patch Set 5 : rebase, remove GPU for now #

Patch Set 6 : tweaks #

Patch Set 7 : fix math #

Patch Set 8 : comment #

Patch Set 9 : printf -> SkDebugf #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+230 lines, -21 lines) Patch
A bench/nanobench.cpp View 1 2 3 4 5 6 7 8 1 chunk +203 lines, -0 lines 0 comments Download
M gyp/bench.gyp View 1 2 3 4 2 chunks +16 lines, -20 lines 5 comments Download
M gyp/bench.gypi View 1 2 3 4 1 chunk +10 lines, -0 lines 0 comments Download
M gyp/most.gyp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
mtklein
6 years, 6 months ago (2014-06-24 20:44:23 UTC) #1
djsollen
is this something you want to submit now or was this just FYI? I think ...
6 years, 6 months ago (2014-06-25 19:52:40 UTC) #2
tfarina
https://codereview.chromium.org/347443002/diff/90005/gyp/bench.gyp File gyp/bench.gyp (right): https://codereview.chromium.org/347443002/diff/90005/gyp/bench.gyp#newcode40 gyp/bench.gyp:40: '../bench/nanobench.cpp', NanoBenchMain.cpp? otherwise can it be either nanobench_main.cpp or ...
6 years, 6 months ago (2014-06-25 20:06:25 UTC) #3
mtklein
Yeah, I figure we land this as a place to iterate new ideas, then just ...
6 years, 6 months ago (2014-06-25 20:28:08 UTC) #4
mtklein
Whelp, Derek's abandoned me for a vacation. Just going to land this.
6 years, 6 months ago (2014-06-25 20:55:02 UTC) #5
mtklein
lgtm
6 years, 6 months ago (2014-06-25 20:55:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/347443002/90005
6 years, 6 months ago (2014-06-25 20:55:49 UTC) #7
commit-bot: I haz the power
Change committed as f372321de3d4183de5b9ca436e677e471e358f31
6 years, 6 months ago (2014-06-25 21:08:04 UTC) #8
tfarina
https://codereview.chromium.org/347443002/diff/90005/gyp/bench.gyp File gyp/bench.gyp (right): https://codereview.chromium.org/347443002/diff/90005/gyp/bench.gyp#newcode40 gyp/bench.gyp:40: '../bench/nanobench.cpp', On 2014/06/25 20:28:08, mtklein wrote: > On 2014/06/25 ...
6 years, 6 months ago (2014-06-25 21:08:04 UTC) #9
mtklein
6 years, 6 months ago (2014-06-25 21:25:39 UTC) #10
Message was sent while issue was closed.
> I don't understand why you call naming a file nanobench_main.cpp or
> nanobenchmain.cpp, complicate anything. If you come later and add a class
> NanoBench then that will complicate things. That is what already happens with
> dump_record.

Yeah, I agree.  If we add a class NanoBench, that complicates things, and we can
rename files then.  But that's not happened yet, or even planned to happen.  I'd
prefer not to guard against or even really think about problems we may not have.
 Some problems need thinking ahead to avoid, but that's not usually true of
software.

Powered by Google App Engine
This is Rietveld 408576698