Issue 347433003: Fix incorrect position of Native Viewport contents on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 347433003: Fix incorrect position of Native Viewport contents on Windows (Closed)

Created:
6 years, 6 months ago by Ben Goodger (Google)

Modified:
6 years, 6 months ago

Reviewers:
sky

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

When you moved the native viewport, the contents would move to an incorrect position due to an issue with non-client/client adjustment in native_viewport_win. Also make the browser app open immediately on startup of the window manager, for convenience. ** Not tested as part of the main chrome integration test suite ** R=sky@chromium.org BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278244

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -7 lines)			Patch
M	mojo/examples/window_manager/window_manager.cc	View	1	2 chunks	+5 lines, -4 lines	0 comments	Download
M	mojo/services/native_viewport/native_viewport_win.cc	View		1 chunk	+5 lines, -2 lines	0 comments	Download
M	mojo/services/view_manager/window_tree_host_impl.cc	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

6 years, 6 months ago (2014-06-19 02:44:27 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r278244 (tree was closed).

Expand Messages | Collapse Messages

Issue 347433003: Fix incorrect position of Native Viewport contents on Windows (Closed)

Description

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Messages