Issue 347423010: Add a test for matchMedia listeners.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 347423010: Add a test for matchMedia listeners. (Closed)

Created:
6 years, 6 months ago by esprehn

Modified:
6 years, 6 months ago

Reviewers:
cbiesinger, eseidel, ojan

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Add a test for matchMedia listeners. This feature has no tests! Lets start by adding the first one. Note that the test will need to change once we stop running the listener inside updateStyle, but that's good, it'll show when we fixed that bug. BUG=356487 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176866

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+67 lines, -0 lines)			Patch
	A	LayoutTests/fast/media/media-query-list-listener.html	View		1 chunk	+52 lines, -0 lines	0 comments	Download
	A	LayoutTests/fast/media/media-query-list-listener-expected.txt	View		1 chunk	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/347423010/1

6 years, 6 months ago (2014-06-24 17:28:03 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...

6 years, 6 months ago (2014-06-24 18:49:48 UTC) #5

Message was sent while issue was closed.

Change committed as 176866

Expand Messages | Collapse Messages