Chromium Code Reviews
DescriptionFix shadow repaint issue in vertical-rl mode
The original code erroneously flipped the shadow edges when the box is
in vertical-rl writing mode, causing incorrect visual overflow and
repaint rects.
Our actual painting code for shadow is correct. The bug is just about
incorrect invalidation rects.
Note because of other bugs about shadow invalidation, the expected
result of the new tests are not correct yet. Will rebaseline them
when the bugs are fixed in later changes.
References:
[1] http://dev.w3.org/csswg/css-writing-modes-3/#physical-only
BUG=388343
TEST=fast/box-shadow/shadow-box-resize-writing-mode.html
TEST=fast/box-shadow/shadow-box-resize.html
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177246
Patch Set 1 #Patch Set 2 : Fix bug first. Refactor later. #
Messages
Total messages: 9 (0 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||