Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 347393007: Fix shadow repaint issue in vertical-rl mode (Closed)

Created:
6 years, 6 months ago by Xianzhu
Modified:
6 years, 5 months ago
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr., rune+blink, zoltan1
Project:
blink
Visibility:
Public.

Description

Fix shadow repaint issue in vertical-rl mode The original code erroneously flipped the shadow edges when the box is in vertical-rl writing mode, causing incorrect visual overflow and repaint rects. Our actual painting code for shadow is correct. The bug is just about incorrect invalidation rects. Note because of other bugs about shadow invalidation, the expected result of the new tests are not correct yet. Will rebaseline them when the bugs are fixed in later changes. References: [1] http://dev.w3.org/csswg/css-writing-modes-3/#physical-only BUG=388343 TEST=fast/box-shadow/shadow-box-resize-writing-mode.html TEST=fast/box-shadow/shadow-box-resize.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177246

Patch Set 1 #

Patch Set 2 : Fix bug first. Refactor later. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -18 lines) Patch
A LayoutTests/fast/box-shadow/shadow-box-resize.html View 1 chunk +44 lines, -0 lines 0 comments Download
A + LayoutTests/fast/box-shadow/shadow-box-resize-expected.txt View 1 chunk +4 lines, -2 lines 0 comments Download
A LayoutTests/fast/box-shadow/shadow-box-resize-writing-mode.html View 1 chunk +45 lines, -0 lines 0 comments Download
A + LayoutTests/fast/box-shadow/shadow-box-resize-writing-mode-expected.txt View 1 chunk +4 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderBox.cpp View 1 2 chunks +9 lines, -14 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Xianzhu
6 years, 6 months ago (2014-06-23 23:51:12 UTC) #1
Xianzhu
Changed bug from crbug.com/380472 to more specific crbug.com/388343.
6 years, 6 months ago (2014-06-24 18:42:48 UTC) #2
Xianzhu
ping...
6 years, 6 months ago (2014-06-26 17:03:48 UTC) #3
Xianzhu
I've made the CL much smaller, leaving refactoring in later changes. PTAL.
6 years, 6 months ago (2014-06-26 22:01:18 UTC) #4
leviw_travelin_and_unemployed
Okay. LGTM.
6 years, 5 months ago (2014-06-30 19:01:20 UTC) #5
leviw_travelin_and_unemployed
The CQ bit was checked by leviw@chromium.org
6 years, 5 months ago (2014-06-30 19:01:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/347393007/20001
6 years, 5 months ago (2014-06-30 19:01:46 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 5 months ago (2014-06-30 20:06:42 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-06-30 23:20:32 UTC) #9
Message was sent while issue was closed.
Change committed as 177246

Powered by Google App Engine
This is Rietveld 408576698