Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 347393005: Missing removeEventListener() arg in assertions.js (Closed)

Created:
6 years, 6 months ago by f(malita)
Modified:
6 years, 6 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, Stephen White
Project:
chromium
Visibility:
Public.

Description

Missing removeEventListener() arg in assertions.js Unreviewed gardening. After https://src.chromium.org/viewvc/blink?revision=176746&view=revision ExternallyConnectableMessagingTest.FromIframeWithPermission is failing due to missing removeEventListener() arg. BUG=353484 TBR=nbarth@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279122

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/test/data/extensions/api_test/messaging/externally_connectable/sites/assertions.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
f(malita)
The CQ bit was checked by fmalita@chromium.org
6 years, 6 months ago (2014-06-23 15:19:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fmalita@chromium.org/347393005/1
6 years, 6 months ago (2014-06-23 15:20:32 UTC) #2
f(malita)
Committed patchset #1 manually as r279122 (presubmit successful).
6 years, 6 months ago (2014-06-23 16:53:50 UTC) #3
haraken
LGTM
6 years, 6 months ago (2014-06-23 23:20:58 UTC) #4
Nils Barth (inactive)
6 years, 6 months ago (2014-06-24 04:48:13 UTC) #5
Message was sent while issue was closed. 
Thanks Florin!

Powered by Google App Engine
This is Rietveld 408576698