Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 347383004: Re-enable device offline alert. (Closed)

Created:
6 years, 5 months ago by zty
Modified:
6 years, 5 months ago
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/android/buildbot/bb_device_status_check.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (0 generated)
zty
Now that the ticket generation is fairly accurate. I would like to re-enable this feature.
6 years, 5 months ago (2014-07-02 00:17:28 UTC) #1
friedman1
lgtm
6 years, 5 months ago (2014-07-02 00:24:03 UTC) #2
zty
The CQ bit was checked by zty@chromium.org
6 years, 5 months ago (2014-07-02 20:24:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zty@chromium.org/347383004/1
6 years, 5 months ago (2014-07-02 20:25:58 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-02 20:25:59 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 5 months ago (2014-07-02 20:26:00 UTC) #6
navabi
lgtm
6 years, 5 months ago (2014-07-02 20:27:27 UTC) #7
zty
The CQ bit was checked by zty@chromium.org
6 years, 5 months ago (2014-07-02 20:29:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zty@chromium.org/347383004/1
6 years, 5 months ago (2014-07-02 20:30:12 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-02 22:19:17 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-02 22:22:41 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/77702)
6 years, 5 months ago (2014-07-02 22:22:42 UTC) #12
zty
The CQ bit was checked by zty@chromium.org
6 years, 5 months ago (2014-07-07 21:27:30 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zty@chromium.org/347383004/1
6 years, 5 months ago (2014-07-07 21:28:44 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 5 months ago (2014-07-07 23:23:46 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-07 23:28:08 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/78348)
6 years, 5 months ago (2014-07-07 23:28:09 UTC) #17
navabi1
lgtm
6 years, 5 months ago (2014-07-08 00:10:57 UTC) #18
zty
The CQ bit was checked by zty@chromium.org
6 years, 5 months ago (2014-07-08 00:11:46 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zty@chromium.org/347383004/1
6 years, 5 months ago (2014-07-08 00:13:34 UTC) #20
commit-bot: I haz the power
6 years, 5 months ago (2014-07-08 00:18:51 UTC) #21
Message was sent while issue was closed.
Change committed as 281609

Powered by Google App Engine
This is Rietveld 408576698