Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 34733007: Add back unseparated out version of method overloads in dart:html. (Closed)

Created:
7 years, 2 months ago by Emily Fortuna
Modified:
7 years, 2 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add back unseparated out version of method overloads in dart:html. BUG= R=blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=29135

Patch Set 1 : #

Patch Set 2 : pete #

Patch Set 3 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+349 lines, -84 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 2 chunks +5 lines, -5 lines 0 comments Download
M sdk/lib/web_gl/dart2js/web_gl_dart2js.dart View 1 2 6 chunks +133 lines, -7 lines 0 comments Download
M sdk/lib/web_gl/dartium/web_gl_dartium.dart View 1 2 8 chunks +110 lines, -18 lines 0 comments Download
M tests/html/webgl_1_test.dart View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M tools/dom/docs/docs.json View 1 2 1 chunk +44 lines, -0 lines 0 comments Download
M tools/dom/docs/lib/docs.dart View 1 2 1 chunk +1 line, -0 lines 2 comments Download
M tools/dom/dom.json View 1 1 chunk +6 lines, -0 lines 0 comments Download
M tools/dom/scripts/htmldartgenerator.py View 1 2 3 chunks +21 lines, -13 lines 0 comments Download
M tools/dom/scripts/htmlrenamer.py View 1 2 6 chunks +11 lines, -19 lines 0 comments Download
M tools/dom/scripts/systemhtml.py View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_WebGLRenderingContext.darttemplate View 1 2 4 chunks +11 lines, -13 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Emily Fortuna
7 years, 2 months ago (2013-10-22 23:58:25 UTC) #1
Emily Fortuna
Oh boy! It's our favorite part of dart:html. So basically this adds back the default ...
7 years, 2 months ago (2013-10-22 23:59:20 UTC) #2
blois
lgtm FYI- the unified diffs usually still work with the upload issues. No worries if ...
7 years, 2 months ago (2013-10-23 21:31:30 UTC) #3
Emily Fortuna
sending out for question to Juniper and/or Dan. No additional reviewing action needed on anyone's ...
7 years, 2 months ago (2013-10-24 00:02:18 UTC) #4
Emily Fortuna
sending out for question to Juniper and/or Dan. No additional reviewing action needed on anyone's ...
7 years, 2 months ago (2013-10-24 00:03:09 UTC) #5
Emily Fortuna
Committed patchset #3 manually as r29135 (presubmit successful).
7 years, 2 months ago (2013-10-24 00:07:57 UTC) #6
Andrei Mouravski
7 years, 2 months ago (2013-10-24 22:24:37 UTC) #7
Message was sent while issue was closed.
https://codereview.chromium.org/34733007/diff/410001/tools/dom/docs/lib/docs....
File tools/dom/docs/lib/docs.dart (right):

https://codereview.chromium.org/34733007/diff/410001/tools/dom/docs/lib/docs....
tools/dom/docs/lib/docs.dart:27: 'dart:web_gl',
On 2013/10/24 00:02:20, Emily Fortuna wrote:
> Dan, Juniper: Is there a reason web_gl wasn't included previously in the
> documentation list here? 

A cane toad jumped on my keyboard and deleted just that one line.
No, there wasn't any reason that I can think of.

Powered by Google App Engine
This is Rietveld 408576698