Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(701)

Issue 3473024: [Isolates] More handle improvements: (Closed)

Created:
10 years, 2 months ago by Vitaly Repeshko
Modified:
9 years, 7 months ago
Reviewers:
yurys
CC:
v8-dev
Visibility:
Public.

Description

[Isolates] More handle improvements: o Automatically extract the current isolate when creating heap object handles. o Pass isolate to HandleScope. o Pass isolate to more runtime functions and prefer Isolate* to Heap*. Committed: http://code.google.com/p/v8/source/detail?r=5546

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+367 lines, -309 lines) Patch
M src/handles.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/handles.cc View 4 chunks +10 lines, -7 lines 0 comments Download
M src/handles-inl.h View 2 chunks +34 lines, -2 lines 0 comments Download
M src/ic.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M src/runtime.h View 1 chunk +7 lines, -6 lines 0 comments Download
M src/runtime.cc View 201 chunks +307 lines, -288 lines 0 comments Download
M test/cctest/test-func-name-inference.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Vitaly Repeshko
10 years, 2 months ago (2010-09-28 12:35:57 UTC) #1
Vitaly Repeshko
10 years, 2 months ago (2010-09-28 12:41:19 UTC) #2
yurys
10 years, 2 months ago (2010-09-28 13:06:58 UTC) #3
On 2010/09/28 12:41:19, Vitaly wrote:
> 

LGTM

Powered by Google App Engine
This is Rietveld 408576698