Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(777)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: base/third_party/dmg_fp/dtoa.cc

Issue 3473006: Fix a bunch of clang warnings/errors. (Closed)
Patch Set: Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/scoped_nsobject.h ('K') | « base/scoped_nsobject.h ('k') | chrome/browser/cocoa/applescript/bookmark_folder_applescript.h » ('j') | chrome/browser/spellcheck_host.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/third_party/dmg_fp/dtoa.cc
diff --git a/base/third_party/dmg_fp/dtoa.cc b/base/third_party/dmg_fp/dtoa.cc
index 3f7e794b354c534f76486d4cbca8f030fc6d4b2a..ad71fb66e1edb49254fc2909a7902f78297100da 100644
--- a/base/third_party/dmg_fp/dtoa.cc
+++ b/base/third_party/dmg_fp/dtoa.cc
@@ -1559,7 +1559,7 @@ hexnan
CONST char *s;
int c1, havedig, udx0, xshift;
- if (!hexdig['0'])
+ if (!hexdig[(int)'0'])
Mark Mentovai 2010/09/21 18:40:01 Edit README.chromium and provide a patch or modify
Evan Martin 2010/09/21 18:52:20 I intentionally didn't make this change when I did
hexdig_init();
x[0] = x[1] = 0;
havedig = xshift = 0;
« base/scoped_nsobject.h ('K') | « base/scoped_nsobject.h ('k') | chrome/browser/cocoa/applescript/bookmark_folder_applescript.h » ('j') | chrome/browser/spellcheck_host.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698