Fix a bunch of clang warnings/errors.

app/l10n_util.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "app/l10n_util.h"
 
 #include <cstdlib>
 
 #include "app/app_paths.h"
 #include "app/l10n_util_collator.h"
@@ skipping 209 matching lines @@
 // lanaguage name). These locales have to be distinguished from the
 // fully populated locales to which Chrome is localized.
 bool IsLocalePartiallyPopulated(const std::string& locale_name) {
   // For partially populated locales, even the translation for "English"
   // is not available. A more robust/elegant way to check is to add a special
   // field (say, 'isPartial' to our version of ICU locale files) and
   // check its value, but this hack seems to work well.
   return !IsLocaleNameTranslated("en", locale_name);
 }
 
+#if !defined(OS_MACOSX)

[Evan Martin, 2010/09/21 18:52:20]

I think we disable the unused function warnings already with gcc.  We have way
too much code to need to worry about which functions are used on which
platforms.  (I recall there being random functions in skia that aren't used for
example.)

 bool IsLocaleAvailable(const std::string& locale,
                        const FilePath& locale_path) {
   // If locale has any illegal characters in it, we don't want to try to
   // load it because it may be pointing outside the locale data file directory.
   if (!file_util::IsFilenameLegal(ASCIIToUTF16(locale)))
     return false;
 
   // IsLocalePartiallyPopulated() can be called here for an early return w/o
   // checking the resource availability below. It'd help when Chrome is run
   // under a system locale Chrome is not localized to (e.g.Farsi on Linux),
@@ skipping 77 matching lines @@
   base::i18n::GetLanguageAndRegionFromOS(&language, &region);
   std::string ret;
   if (!language.empty())
     ret.append(language);
   if (!region.empty()) {
     ret.append("-");
     ret.append(region);
   }
   return ret;
 }
+#endif
 
 #if defined(OS_POSIX) && !defined(OS_MACOSX)
 // Split and normalize the language list specified by LANGUAGE environment.
 // LANGUAGE environment specifies a priority list of user prefered locales for
 // application UI messages. Locales are separated by ':' character. The format
 // of a locale is: language[_territory[.codeset]][@modifier]
 //
 // This function splits the language list and normalizes each locale into
 // language[-territory] format, eg. fr, zh-CN, etc.
 void SplitAndNormalizeLanguageList(const std::string& env_language,
@@ skipping 524 matching lines @@
   for (size_t i = 0; i < arraysize(kAcceptLanguageList); ++i) {
     if (!IsLocaleNameTranslated(kAcceptLanguageList[i], display_locale))
       // TODO(jungshik) : Put them at the of the list with language codes
       // enclosed by brackets instead of skipping.
         continue;
     locale_codes->push_back(kAcceptLanguageList[i]);
   }
 }
 
 }  // namespace l10n_util