Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 347223004: Remove dependency from platform.h implementations on isolate (Closed)

Created:
6 years, 6 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 6 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Remove dependency from platform.h implementations on isolate BUG=none R=bmeurer@chromium.org LOG=n Committed: https://code.google.com/p/v8/source/detail?r=21997

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -53 lines) Patch
M src/platform.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/platform-posix.cc View 3 chunks +34 lines, -30 lines 0 comments Download
M src/platform-win32.cc View 2 chunks +25 lines, -22 lines 0 comments Download
M src/utils/random-number-generator.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/v8.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
6 years, 6 months ago (2014-06-24 20:07:18 UTC) #1
Benedikt Meurer
Nice refactoring, LGTM.
6 years, 6 months ago (2014-06-25 05:29:44 UTC) #2
jochen (gone - plz use gerrit)
6 years, 6 months ago (2014-06-25 08:20:52 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21997 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698