Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Unified Diff: components/autofill/core/browser/contact_info.h

Issue 347183005: autofill names - dont parse when calling SetRawInfo(FULL_NAME) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix buncha stuff Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/contact_info.h
diff --git a/components/autofill/core/browser/contact_info.h b/components/autofill/core/browser/contact_info.h
index 5478a165e024d681e74674853ba2390234646c92..5cbef816e8c9d62d76965bb8f866db073925eab4 100644
--- a/components/autofill/core/browser/contact_info.h
+++ b/components/autofill/core/browser/contact_info.h
@@ -25,12 +25,17 @@ class NameInfo : public FormGroup {
// Compares |NameInfo| objects for |first_|, |middle_| and |last_| names,
Ilya Sherman 2014/06/27 06:25:08 nit: "first_" and "last_" should be updated to "gi
Evan Stade 2014/06/28 01:01:35 Done.
// ignoring their case differences.
- bool EqualsIgnoreCase(const NameInfo& info);
+ bool ParsedBitsAreEqual(const NameInfo& info);
Ilya Sherman 2014/06/27 06:25:08 nit: "bits" makes me think of binary digits. Perh
Evan Stade 2014/06/28 01:01:35 Done.
// FormGroup:
virtual base::string16 GetRawInfo(ServerFieldType type) const OVERRIDE;
virtual void SetRawInfo(ServerFieldType type,
const base::string16& value) OVERRIDE;
+ virtual base::string16 GetInfo(const AutofillType& type,
+ const std::string& app_locale) const OVERRIDE;
+ virtual bool SetInfo(const AutofillType& type,
+ const base::string16& value,
+ const std::string& app_locale) OVERRIDE;
private:
// FormGroup:

Powered by Google App Engine
This is Rietveld 408576698