chrome/browser/ui/autofill/autofill_dialog_i18n_input.cc - Issue 347183005: autofill names - dont parse when calling SetRawInfo(FULL_NAME)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/autofill/autofill_dialog_i18n_input.cc

Issue 347183005: autofill names - dont parse when calling SetRawInfo(FULL_NAME) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix android test expectation Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/autofill/autofill_dialog_i18n_input.cc

diff --git a/chrome/browser/ui/autofill/autofill_dialog_i18n_input.cc b/chrome/browser/ui/autofill/autofill_dialog_i18n_input.cc

index 6fe305c3797bf0e9338709d705e49401085ff96c..94ff4aa121cf2be41a6c0385e3e9cec08577f1c1 100644

--- a/chrome/browser/ui/autofill/autofill_dialog_i18n_input.cc

+++ b/chrome/browser/ui/autofill/autofill_dialog_i18n_input.cc

@@ -99,8 +99,10 @@ bool AddressHasCompleteAndVerifiedData(const AutofillProfile& profile,

};

for (size_t i = 0; i < arraysize(more_required_fields); ++i) {

- if (profile.GetRawInfo(more_required_fields[i]).empty())

+ if (profile.GetInfo(AutofillType(more_required_fields[i]),

+ app_locale).empty()) {

return false;

+ }

}

return true;