autofill names - dont parse when calling SetRawInfo(FULL_NAME)

components/autofill/core/browser/address_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "base/strings/string16.h"
 #include "base/strings/utf_string_conversions.h"
 #include "components/autofill/core/browser/address.h"
 #include "components/autofill/core/browser/autofill_type.h"
@@ skipping 243 matching lines @@
             address.GetRawInfo(ADDRESS_HOME_LINE1));
   EXPECT_EQ(base::string16(), address.GetRawInfo(ADDRESS_HOME_LINE2));
 
   // An empty address should clear out all address lines.
   address.SetRawInfo(ADDRESS_HOME_STREET_ADDRESS, long_street_address);
   address.SetRawInfo(ADDRESS_HOME_STREET_ADDRESS, empty_street_address);
   EXPECT_EQ(base::string16(), address.GetRawInfo(ADDRESS_HOME_LINE1));
   EXPECT_EQ(base::string16(), address.GetRawInfo(ADDRESS_HOME_LINE2));
 }
 
-// Verifies that Address::SetInfo() rejects setting data for
-// ADDRESS_HOME_STREET_ADDRESS without newlines, as there is no good general way
-// to parse that data into the consituent address lines. Addresses without
-// newlines should be set properly.
+// Street addresses should be set properly.
 TEST(AddressTest, SetStreetAddress) {
   const base::string16 empty_street_address;
-  const base::string16 one_line_street_address =
-      ASCIIToUTF16("456 New St., Apt. 17");
   const base::string16 multi_line_street_address =
       ASCIIToUTF16("789 Fancy Pkwy.\n"
                    "Unit 3.14\n"
                    "Box 9");
+  const base::string16 single_line_street_address =
+      ASCIIToUTF16("123 Main, Apt 7");
   const AutofillType type = AutofillType(ADDRESS_HOME_STREET_ADDRESS);
 
   // Start with a non-empty address.
   Address address;
   address.SetRawInfo(ADDRESS_HOME_LINE1, ASCIIToUTF16("123 Example Ave."));
   address.SetRawInfo(ADDRESS_HOME_LINE2, ASCIIToUTF16("Apt. 42"));
   address.SetRawInfo(ADDRESS_HOME_LINE3, ASCIIToUTF16("and a half"));
   EXPECT_FALSE(address.GetRawInfo(ADDRESS_HOME_LINE1).empty());
   EXPECT_FALSE(address.GetRawInfo(ADDRESS_HOME_LINE2).empty());
   EXPECT_FALSE(address.GetRawInfo(ADDRESS_HOME_LINE3).empty());
 
-  // Attempting to set a one-line address should fail, as the single line might
-  // actually represent multiple logical lines, combined into one due to the
-  // user having to work around constraints imposed by the website.
-  EXPECT_FALSE(address.SetInfo(type, one_line_street_address, "en-US"));
-  EXPECT_EQ(base::string16(), address.GetRawInfo(ADDRESS_HOME_LINE1));
-  EXPECT_EQ(base::string16(), address.GetRawInfo(ADDRESS_HOME_LINE2));
-  EXPECT_EQ(base::string16(), address.GetRawInfo(ADDRESS_HOME_LINE3));
-
   // Attempting to set a multi-line address should succeed.
   EXPECT_TRUE(address.SetInfo(type, multi_line_street_address, "en-US"));
   EXPECT_EQ(ASCIIToUTF16("789 Fancy Pkwy."),
             address.GetRawInfo(ADDRESS_HOME_LINE1));
   EXPECT_EQ(ASCIIToUTF16("Unit 3.14"), address.GetRawInfo(ADDRESS_HOME_LINE2));
   EXPECT_EQ(ASCIIToUTF16("Box 9"), address.GetRawInfo(ADDRESS_HOME_LINE3));
 
+  // Setting a single line street address should clear out subsequent lines.
+  EXPECT_TRUE(address.SetInfo(type, single_line_street_address, "en-US"));
+  EXPECT_EQ(single_line_street_address, address.GetRawInfo(ADDRESS_HOME_LINE1));
+  EXPECT_EQ(base::string16(), address.GetRawInfo(ADDRESS_HOME_LINE2));
+  EXPECT_EQ(base::string16(), address.GetRawInfo(ADDRESS_HOME_LINE3));
+
   // Attempting to set an empty address should also succeed, and clear out the
   // previously stored data.
   EXPECT_FALSE(address.GetRawInfo(ADDRESS_HOME_LINE1).empty());

[Ilya Sherman, 2014/07/01 02:55:17]

IMO it's good to start with all lines non-empty, and then end up with all lines
empty.  That provides slightly more test coverage.

[Evan Stade, 2014/07/01 23:18:52]

fair enough, fixed

-  EXPECT_FALSE(address.GetRawInfo(ADDRESS_HOME_LINE2).empty());
-  EXPECT_FALSE(address.GetRawInfo(ADDRESS_HOME_LINE3).empty());
   EXPECT_TRUE(address.SetInfo(type, empty_street_address, "en-US"));
   EXPECT_EQ(base::string16(), address.GetRawInfo(ADDRESS_HOME_LINE1));
   EXPECT_EQ(base::string16(), address.GetRawInfo(ADDRESS_HOME_LINE2));
   EXPECT_EQ(base::string16(), address.GetRawInfo(ADDRESS_HOME_LINE3));
 }
 
 // Verifies that Address::SetInfio() rejects setting data for
 // ADDRESS_HOME_STREET_ADDRESS if the data has any interior blank lines.
 TEST(AddressTest, SetStreetAddressRejectsAddressesWithInteriorBlankLines) {
   // Start with a non-empty address.
@@ skipping 56 matching lines @@
                                ASCIIToUTF16("Address line 1"
                                             "Address line 2"
                                             "\n"),
                                "en-US"));
   EXPECT_EQ(base::string16(), address.GetRawInfo(ADDRESS_HOME_LINE1));
   EXPECT_EQ(base::string16(), address.GetRawInfo(ADDRESS_HOME_LINE2));
   EXPECT_EQ(base::string16(), address.GetRawInfo(ADDRESS_HOME_STREET_ADDRESS));
 }
 
 }  // namespace autofill