autofill names - dont parse when calling SetRawInfo(FULL_NAME)

components/autofill/core/browser/address.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/address.h"
 
 #include <stddef.h>
 #include <algorithm>
 
 #include "base/basictypes.h"
@@ skipping 154 matching lines @@
     // Parsing a full address is too hard.
     return false;
   }
 
   ServerFieldType storable_type = type.GetStorableType();
   if (storable_type == ADDRESS_HOME_COUNTRY && !value.empty()) {
     country_code_ = AutofillCountry::GetCountryCode(value, app_locale);
     return !country_code_.empty();
   }
 
-  // If the address doesn't have any newlines, don't attempt to parse it into
-  // lines, since this is potentially a user-entered address in the user's own
-  // format, so the code would have to rely on iffy heuristics at best.
-  // Instead, just give up when importing addresses like this.
-  if (storable_type == ADDRESS_HOME_STREET_ADDRESS && !value.empty() &&

[Evan Stade, 2014/06/28 01:01:35]

this behavior was causing problems when I was trying to call SetInfo for data
entered via requestAutocomplete. I decided to delete this code because I don't
really agree with the logic behind it. "123 Main St, Apt 7" is a perfectly way
to type an address and doesn't need to be broken up into multiple address lines.

-      value.find(base::char16('\n')) == base::string16::npos) {
-    street_address_.clear();
-    return false;
-  }
-
   SetRawInfo(storable_type, value);
 
-  // Likewise, give up when importing addresses with any entirely blank lines.
+  // Give up when importing addresses with any entirely blank lines.
   // There's a good chance that this formatting is not intentional, but it's
   // also not obviously safe to just strip the newlines.
   if (storable_type == ADDRESS_HOME_STREET_ADDRESS &&
       std::find(street_address_.begin(), street_address_.end(),
                 base::string16()) != street_address_.end()) {
     street_address_.clear();
     return false;
   }
 
   return true;
@@ skipping 23 matching lines @@
   supported_types->insert(ADDRESS_HOME_COUNTRY);
 }
 
 void Address::TrimStreetAddress() {
   while (!street_address_.empty() && street_address_.back().empty()) {
     street_address_.pop_back();
   }
 }
 
 }  // namespace autofill