autofill names - dont parse when calling SetRawInfo(FULL_NAME)

components/autofill/core/browser/webdata/autofill_profile_syncable_service_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/location.h"
 #include "base/message_loop/message_loop.h"
 #include "base/strings/utf_string_conversions.h"
 #include "components/autofill/core/browser/autofill_profile.h"
 #include "components/autofill/core/browser/webdata/autofill_change.h"
 #include "components/autofill/core/browser/webdata/autofill_profile_syncable_service.h"
@@ skipping 119 matching lines @@
 // Returns a profile with all fields set.  Contains identical data to the data
 // returned from ConstructCompleteSyncData().
 scoped_ptr<AutofillProfile> ConstructCompleteProfile() {
   scoped_ptr<AutofillProfile> profile(
       new AutofillProfile(kGuid1, kHttpsOrigin));
 
   std::vector<base::string16> names;
   names.push_back(ASCIIToUTF16("John K. Doe, Jr."));
   names.push_back(ASCIIToUTF16("Jane Luise Smith MD"));
   profile->SetRawMultiInfo(NAME_FULL, names);
+  names.clear();
+  names.push_back(ASCIIToUTF16("John"));
+  names.push_back(ASCIIToUTF16("Jane"));
+  profile->SetRawMultiInfo(NAME_FIRST, names);
+  names.clear();
+  names.push_back(ASCIIToUTF16("K."));
+  names.push_back(ASCIIToUTF16("Luise"));
+  profile->SetRawMultiInfo(NAME_MIDDLE, names);
+  names.clear();
+  names.push_back(ASCIIToUTF16("Doe"));
+  names.push_back(ASCIIToUTF16("Smith"));
+  profile->SetRawMultiInfo(NAME_LAST, names);
 
   std::vector<base::string16> emails;
   emails.push_back(ASCIIToUTF16("user@example.com"));
   emails.push_back(ASCIIToUTF16("superuser@example.org"));
   profile->SetRawMultiInfo(EMAIL_ADDRESS, emails);
 
   std::vector<base::string16> phones;
   phones.push_back(ASCIIToUTF16("1.800.555.1234"));
   phones.push_back(ASCIIToUTF16("1.866.650.0000"));
   profile->SetRawMultiInfo(PHONE_HOME_WHOLE_NUMBER, phones);
@@ skipping 291 matching lines @@
   profiles_from_web_db.push_back(new AutofillProfile(profile));
 
   // Create a Sync profile identical to |profile|, except with no origin set.
   sync_pb::EntitySpecifics specifics;
   sync_pb::AutofillProfileSpecifics* autofill_specifics =
       specifics.mutable_autofill_profile();
   autofill_specifics->set_guid(profile.guid());
   autofill_specifics->add_name_first("John");
   autofill_specifics->add_name_middle(std::string());
   autofill_specifics->add_name_last(std::string());
-  autofill_specifics->add_name_full("John");
+  autofill_specifics->add_name_full(std::string());
   autofill_specifics->add_email_address(std::string());
   autofill_specifics->add_phone_home_whole_number(std::string());
   autofill_specifics->set_address_home_line1("1 1st st");
   EXPECT_FALSE(autofill_specifics->has_origin());
 
   syncer::SyncDataList data_list;
   data_list.push_back(
       syncer::SyncData::CreateLocalData(
           profile.guid(), profile.guid(), specifics));
 
@@ skipping 424 matching lines @@
   profiles_from_web_db.push_back(new AutofillProfile(profile));
 
   // Remote data does not have an origin value.
   sync_pb::EntitySpecifics specifics;
   sync_pb::AutofillProfileSpecifics* autofill_specifics =
       specifics.mutable_autofill_profile();
   autofill_specifics->set_guid(profile.guid());
   autofill_specifics->add_name_first("John");
   autofill_specifics->add_name_middle(std::string());
   autofill_specifics->add_name_last(std::string());
-  autofill_specifics->add_name_full("John");
+  autofill_specifics->add_name_full(std::string());
   autofill_specifics->add_email_address(std::string());
   autofill_specifics->add_phone_home_whole_number(std::string());
   EXPECT_FALSE(autofill_specifics->has_origin());
 
   syncer::SyncDataList data_list;
   data_list.push_back(
       syncer::SyncData::CreateLocalData(
           profile.guid(), profile.guid(), specifics));
 
   // Expect the local autofill profile to still have an origin after sync.
@@ skipping 145 matching lines @@
 
   // Remote data does not have a language code value.
   sync_pb::EntitySpecifics specifics;
   sync_pb::AutofillProfileSpecifics* autofill_specifics =
       specifics.mutable_autofill_profile();
   autofill_specifics->set_guid(profile.guid());
   autofill_specifics->set_origin(profile.origin());
   autofill_specifics->add_name_first("John");
   autofill_specifics->add_name_middle(std::string());
   autofill_specifics->add_name_last(std::string());
-  autofill_specifics->add_name_full("John");
+  autofill_specifics->add_name_full(std::string());
   autofill_specifics->add_email_address(std::string());
   autofill_specifics->add_phone_home_whole_number(std::string());
   EXPECT_FALSE(autofill_specifics->has_address_home_language_code());
 
   syncer::SyncDataList data_list;
   data_list.push_back(
       syncer::SyncData::CreateLocalData(
           profile.guid(), profile.guid(), specifics));
 
   // Expect local autofill profile to still have "en" language code after sync.
@@ skipping 65 matching lines @@
   MergeDataAndStartSyncing(profiles_from_web_db, data_list,
                            expected_empty_bundle, expected_empty_change_list);
   autofill_syncable_service_.StopSyncing(syncer::AUTOFILL_PROFILE);
 }
 
 TEST_F(AutofillProfileSyncableServiceTest, EmptySyncPreservesFullName) {
   std::vector<AutofillProfile*> profiles_from_web_db;
 
   // Local autofill profile has a full name.
   AutofillProfile profile(kGuid1, kHttpsOrigin);
-  profile.SetRawInfo(NAME_FULL, ASCIIToUTF16("John Jacob Smith, Jr"));
+  profile.SetInfo(AutofillType(NAME_FULL),
+                  ASCIIToUTF16("John Jacob Smith, Jr"), "en-US");
   profiles_from_web_db.push_back(new AutofillProfile(profile));
 
   // Remote data does not have a full name value.
   sync_pb::EntitySpecifics specifics;
   sync_pb::AutofillProfileSpecifics* autofill_specifics =
       specifics.mutable_autofill_profile();
   autofill_specifics->set_guid(profile.guid());
   autofill_specifics->set_origin(profile.origin());
   autofill_specifics->add_name_first(std::string("John"));
   autofill_specifics->add_name_middle(std::string("Jacob"));
   autofill_specifics->add_name_last(std::string("Smith"));
 
   syncer::SyncDataList data_list;
   data_list.push_back(
       syncer::SyncData::CreateLocalData(
           profile.guid(), profile.guid(), specifics));
 
   // Expect local autofill profile to still have the same full name after sync.
   MockAutofillProfileSyncableService::DataBundle expected_bundle;
   AutofillProfile expected_profile(profile.guid(), profile.origin());
-  expected_profile.SetRawInfo(NAME_FULL, ASCIIToUTF16("John Jacob Smith, Jr"));
+  expected_profile.SetInfo(AutofillType(NAME_FULL),
+                           ASCIIToUTF16("John Jacob Smith, Jr"),
+                           "en-US");
   expected_bundle.profiles_to_update.push_back(&expected_profile);
 
   // Expect no changes to remote data.
   syncer::SyncChangeList expected_empty_change_list;
 
   MergeDataAndStartSyncing(profiles_from_web_db, data_list,
                            expected_bundle, expected_empty_change_list);
   autofill_syncable_service_.StopSyncing(syncer::AUTOFILL_PROFILE);
 }
 
 }  // namespace autofill