autofill names - dont parse when calling SetRawInfo(FULL_NAME)

components/autofill/core/browser/autofill_profile_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/basictypes.h"
 #include "base/format_macros.h"
 #include "base/guid.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/scoped_vector.h"
 #include "base/stl_util.h"
@@ skipping 11 matching lines @@
 using base::ASCIIToUTF16;
 
 namespace autofill {
 
 namespace {
 
 base::string16 GetLabel(AutofillProfile* profile) {
   std::vector<AutofillProfile*> profiles;
   profiles.push_back(profile);
   std::vector<base::string16> labels;
-  AutofillProfile::CreateDifferentiatingLabels(profiles, &labels);
+  AutofillProfile::CreateDifferentiatingLabels(profiles, "en-US", &labels);
   return labels[0];
 }
 
 // Holds the autofill profile |first|, |middle| and |last| names.
 struct NameParts {
   NameParts(const std::string& first,
             const std::string& middle,
             const std::string& last)
       : first(first), middle(middle), last(last) {}
 
@@ skipping 126 matching lines @@
   // Case 7a: "<firstname> <lastname>, <address>" - same as #7, except for
   // e-mail.
   AutofillProfile profile7a(base::GenerateGUID(), "https://www.example.com/");
   test::SetProfileInfo(&profile7a, "Marion", "Mitchell",
     "Morrison", "marion@me.xyz", "Fox", "123 Zoo St.", "unit 5",
     "Hollywood", "CA", "91601", "US", "16505678910");
   std::vector<AutofillProfile*> profiles;
   profiles.push_back(&profile7);
   profiles.push_back(&profile7a);
   std::vector<base::string16> labels;
-  AutofillProfile::CreateDifferentiatingLabels(profiles, &labels);
+  AutofillProfile::CreateDifferentiatingLabels(profiles, "en-US", &labels);
   ASSERT_EQ(profiles.size(), labels.size());
   summary7 = labels[0];
   base::string16 summary7a = labels[1];
   EXPECT_EQ(ASCIIToUTF16(
       "Marion Mitchell Morrison, 123 Zoo St., johnwayne@me.xyz"), summary7);
   EXPECT_EQ(ASCIIToUTF16(
       "Marion Mitchell Morrison, 123 Zoo St., marion@me.xyz"), summary7a);
 }
 
 TEST(AutofillProfileTest, AdjustInferredLabels) {
@@ skipping 22 matching lines @@
       "Doe",
       "janedoe@tertium.com",
       "Pluto Inc.",
       "123 Letha Shore.",
       "",
       "Dis", "CA",
       "91222",
       "US",
       "12345678910");
   std::vector<base::string16> labels;
-  AutofillProfile::CreateDifferentiatingLabels(profiles.get(), &labels);
+  AutofillProfile::CreateDifferentiatingLabels(
+      profiles.get(), "en-US", &labels);
   ASSERT_EQ(2U, labels.size());
   EXPECT_EQ(ASCIIToUTF16("John Doe, 666 Erebus St."), labels[0]);
   EXPECT_EQ(ASCIIToUTF16("Jane Doe, 123 Letha Shore."), labels[1]);
 
   profiles.push_back(
       new AutofillProfile(base::GenerateGUID(), "Chrome settings"));
   test::SetProfileInfo(
       profiles[2],
       "John",
       "",
       "Doe",
       "johndoe@tertium.com",
       "Underworld",
       "666 Erebus St.",
       "",
       "Elysium", "CA",
       "91111",
       "US",
       "16502111111");
   labels.clear();
-  AutofillProfile::CreateDifferentiatingLabels(profiles.get(), &labels);
+  AutofillProfile::CreateDifferentiatingLabels(
+      profiles.get(), "en-US", &labels);
 
   // Profile 0 and 2 inferred label now includes an e-mail.
   ASSERT_EQ(3U, labels.size());
   EXPECT_EQ(ASCIIToUTF16("John Doe, 666 Erebus St., johndoe@hades.com"),
             labels[0]);
   EXPECT_EQ(ASCIIToUTF16("Jane Doe, 123 Letha Shore."), labels[1]);
   EXPECT_EQ(ASCIIToUTF16("John Doe, 666 Erebus St., johndoe@tertium.com"),
             labels[2]);
 
   profiles.resize(2);
 
   profiles.push_back(
       new AutofillProfile(base::GenerateGUID(), std::string()));
   test::SetProfileInfo(
       profiles[2],
       "John",
       "",
       "Doe",
       "johndoe@hades.com",
       "Underworld",
       "666 Erebus St.",
       "",
       "Elysium", "CO",  // State is different
       "91111",
       "US",
       "16502111111");
 
   labels.clear();
-  AutofillProfile::CreateDifferentiatingLabels(profiles.get(), &labels);
+  AutofillProfile::CreateDifferentiatingLabels(
+      profiles.get(), "en-US", &labels);
 
   // Profile 0 and 2 inferred label now includes a state.
   ASSERT_EQ(3U, labels.size());
   EXPECT_EQ(ASCIIToUTF16("John Doe, 666 Erebus St., CA"), labels[0]);
   EXPECT_EQ(ASCIIToUTF16("Jane Doe, 123 Letha Shore."), labels[1]);
   EXPECT_EQ(ASCIIToUTF16("John Doe, 666 Erebus St., CO"), labels[2]);
 
   profiles.push_back(
       new AutofillProfile(base::GenerateGUID(), "https://www.example.com/"));
   test::SetProfileInfo(
       profiles[3],
       "John",
       "",
       "Doe",
       "johndoe@hades.com",
       "Underworld",
       "666 Erebus St.",
       "",
       "Elysium", "CO",  // State is different for some.
       "91111",
       "US",
       "16504444444");  // Phone is different for some.
 
   labels.clear();
-  AutofillProfile::CreateDifferentiatingLabels(profiles.get(), &labels);
+  AutofillProfile::CreateDifferentiatingLabels(
+      profiles.get(), "en-US", &labels);
   ASSERT_EQ(4U, labels.size());
   EXPECT_EQ(ASCIIToUTF16("John Doe, 666 Erebus St., CA"), labels[0]);
   EXPECT_EQ(ASCIIToUTF16("Jane Doe, 123 Letha Shore."), labels[1]);
   EXPECT_EQ(ASCIIToUTF16("John Doe, 666 Erebus St., CO, 16502111111"),
             labels[2]);
   // This one differs from other ones by unique phone, so no need for extra
   // information.
   EXPECT_EQ(ASCIIToUTF16("John Doe, 666 Erebus St., CO, 16504444444"),
             labels[3]);
 
   profiles.push_back(
       new AutofillProfile(base::GenerateGUID(), "https://www.example.com/"));
   test::SetProfileInfo(
       profiles[4],
       "John",
       "",
       "Doe",
       "johndoe@styx.com",  // E-Mail is different for some.
       "Underworld",
       "666 Erebus St.",
       "",
       "Elysium", "CO",  // State is different for some.
       "91111",
       "US",
       "16504444444");  // Phone is different for some.
 
   labels.clear();
-  AutofillProfile::CreateDifferentiatingLabels(profiles.get(), &labels);
+  AutofillProfile::CreateDifferentiatingLabels(
+      profiles.get(), "en-US", &labels);
   ASSERT_EQ(5U, labels.size());
   EXPECT_EQ(ASCIIToUTF16("John Doe, 666 Erebus St., CA"), labels[0]);
   EXPECT_EQ(ASCIIToUTF16("Jane Doe, 123 Letha Shore."), labels[1]);
   EXPECT_EQ(ASCIIToUTF16("John Doe, 666 Erebus St., CO, johndoe@hades.com,"
                          " 16502111111"), labels[2]);
   EXPECT_EQ(ASCIIToUTF16("John Doe, 666 Erebus St., CO, johndoe@hades.com,"
                          " 16504444444"), labels[3]);
   // This one differs from other ones by unique e-mail, so no need for extra
   // information.
   EXPECT_EQ(ASCIIToUTF16("John Doe, 666 Erebus St., CO, johndoe@styx.com"),
@@ skipping 26 matching lines @@
                        "Pluto Inc.",
                        "123 Letha Shore.",
                        "",
                        "Dis", "CA",
                        "91222",
                        "US",
                        "12345678910");
   std::vector<base::string16> labels;
   // Two fields at least - no filter.
   AutofillProfile::CreateInferredLabels(profiles.get(), NULL, UNKNOWN_TYPE, 2,
-                                        &labels);
+                                        "en-US", &labels);
   EXPECT_EQ(ASCIIToUTF16("John Doe, 666 Erebus St."), labels[0]);
   EXPECT_EQ(ASCIIToUTF16("Jane Doe, 123 Letha Shore."), labels[1]);
 
   // Three fields at least - no filter.
   AutofillProfile::CreateInferredLabels(profiles.get(), NULL, UNKNOWN_TYPE, 3,
-                                        &labels);
+                                        "en-US", &labels);
   EXPECT_EQ(ASCIIToUTF16("John Doe, 666 Erebus St., Elysium"),
             labels[0]);
   EXPECT_EQ(ASCIIToUTF16("Jane Doe, 123 Letha Shore., Dis"),
             labels[1]);
 
   std::vector<ServerFieldType> suggested_fields;
   suggested_fields.push_back(ADDRESS_HOME_CITY);
   suggested_fields.push_back(ADDRESS_HOME_STATE);
   suggested_fields.push_back(ADDRESS_HOME_ZIP);
 
   // Two fields at least, from suggested fields - no filter.
   AutofillProfile::CreateInferredLabels(profiles.get(), &suggested_fields,
-                                        UNKNOWN_TYPE, 2, &labels);
+                                        UNKNOWN_TYPE, 2, "en-US", &labels);
   EXPECT_EQ(ASCIIToUTF16("Elysium, CA"), labels[0]);
   EXPECT_EQ(ASCIIToUTF16("Dis, CA"), labels[1]);
 
   // Three fields at least, from suggested fields - no filter.
   AutofillProfile::CreateInferredLabels(profiles.get(), &suggested_fields,
-                                        UNKNOWN_TYPE, 3, &labels);
+                                        UNKNOWN_TYPE, 3, "en-US", &labels);
   EXPECT_EQ(ASCIIToUTF16("Elysium, CA, 91111"), labels[0]);
   EXPECT_EQ(ASCIIToUTF16("Dis, CA, 91222"), labels[1]);
 
   // Three fields at least, from suggested fields - but filter reduces available
   // fields to two.
   AutofillProfile::CreateInferredLabels(profiles.get(), &suggested_fields,
-                                        ADDRESS_HOME_STATE, 3, &labels);
+                                        ADDRESS_HOME_STATE, 3, "en-US",
+                                        &labels);
   EXPECT_EQ(ASCIIToUTF16("Elysium, 91111"), labels[0]);
   EXPECT_EQ(ASCIIToUTF16("Dis, 91222"), labels[1]);
 
   suggested_fields.clear();
   // In our implementation we always display NAME_FULL for all NAME* fields...
   suggested_fields.push_back(NAME_MIDDLE);
   // One field at least, from suggested fields - no filter.
   AutofillProfile::CreateInferredLabels(profiles.get(), &suggested_fields,
-                                        UNKNOWN_TYPE, 1, &labels);
+                                        UNKNOWN_TYPE, 1, "en-US", &labels);
   EXPECT_EQ(ASCIIToUTF16("John Doe"), labels[0]);
   EXPECT_EQ(ASCIIToUTF16("Jane Doe"), labels[1]);
 
   // One field at least, from suggested fields - filter the same as suggested
   // field.
   AutofillProfile::CreateInferredLabels(profiles.get(), &suggested_fields,
-                                        NAME_MIDDLE, 1, &labels);
+                                        NAME_MIDDLE, 1, "en-US", &labels);
   EXPECT_EQ(base::string16(), labels[0]);
   EXPECT_EQ(base::string16(), labels[1]);
 
   suggested_fields.clear();
   // In our implementation we always display NAME_FULL for NAME_MIDDLE_INITIAL
   suggested_fields.push_back(NAME_MIDDLE_INITIAL);
   // One field at least, from suggested fields - no filter.
   AutofillProfile::CreateInferredLabels(profiles.get(), &suggested_fields,
-                                        UNKNOWN_TYPE, 1, &labels);
+                                        UNKNOWN_TYPE, 1, "en-US", &labels);
   EXPECT_EQ(ASCIIToUTF16("John Doe"), labels[0]);
   EXPECT_EQ(ASCIIToUTF16("Jane Doe"), labels[1]);
 
   // One field at least, from suggested fields - filter same as the first non-
   // unknown suggested field.
   suggested_fields.clear();
   suggested_fields.push_back(UNKNOWN_TYPE);
   suggested_fields.push_back(NAME_FULL);
   suggested_fields.push_back(ADDRESS_HOME_LINE1);
   AutofillProfile::CreateInferredLabels(profiles.get(), &suggested_fields,
-                                        NAME_FULL, 1, &labels);
+                                        NAME_FULL, 1, "en-US", &labels);
   EXPECT_EQ(base::string16(ASCIIToUTF16("666 Erebus St.")), labels[0]);
   EXPECT_EQ(base::string16(ASCIIToUTF16("123 Letha Shore.")), labels[1]);
 }
 
 // Test that we fall back to using the full name if there are no other
 // distinguishing fields, but only if it makes sense given the suggested fields.
 TEST(AutofillProfileTest, CreateInferredLabelsFallsBackToFullName) {
   ScopedVector<AutofillProfile> profiles;
   profiles.push_back(
       new AutofillProfile(base::GenerateGUID(), "https://www.example.com/"));
   test::SetProfileInfo(profiles[0],
                        "John", "", "Doe", "doe@example.com", "",
                        "88 Nowhere Ave.", "", "", "", "", "", "");
   profiles.push_back(
       new AutofillProfile(base::GenerateGUID(), "https://www.example.com/"));
   test::SetProfileInfo(profiles[1],
                        "Johnny", "K", "Doe", "doe@example.com", "",
                        "88 Nowhere Ave.", "", "", "", "", "", "");
 
   // If the only name field in the suggested fields is the excluded field, we
   // should not fall back to the full name as a distinguishing field.
   std::vector<ServerFieldType> suggested_fields;
   suggested_fields.push_back(NAME_LAST);
   suggested_fields.push_back(ADDRESS_HOME_LINE1);
   suggested_fields.push_back(EMAIL_ADDRESS);
   std::vector<base::string16> labels;
   AutofillProfile::CreateInferredLabels(profiles.get(), &suggested_fields,
-                                        NAME_LAST, 1, &labels);
+                                        NAME_LAST, 1, "en-US", &labels);
   ASSERT_EQ(2U, labels.size());
   EXPECT_EQ(ASCIIToUTF16("88 Nowhere Ave."), labels[0]);
   EXPECT_EQ(ASCIIToUTF16("88 Nowhere Ave."), labels[1]);
 
   // Otherwise, we should.
   suggested_fields.push_back(NAME_FIRST);
   AutofillProfile::CreateInferredLabels(profiles.get(),  &suggested_fields,
-                                        NAME_LAST, 1, &labels);
+                                        NAME_LAST, 1, "en-US", &labels);
   ASSERT_EQ(2U, labels.size());
   EXPECT_EQ(ASCIIToUTF16("88 Nowhere Ave., John Doe"), labels[0]);
   EXPECT_EQ(ASCIIToUTF16("88 Nowhere Ave., Johnny K Doe"), labels[1]);
 }
 
 // Test that we do not show duplicate fields in the labels.
 TEST(AutofillProfileTest, CreateInferredLabelsNoDuplicatedFields) {
   ScopedVector<AutofillProfile> profiles;
   profiles.push_back(
       new AutofillProfile(base::GenerateGUID(), "https://www.example.com/"));
   test::SetProfileInfo(profiles[0],
                        "John", "", "Doe", "doe@example.com", "",
                        "88 Nowhere Ave.", "", "", "", "", "", "");
   profiles.push_back(
       new AutofillProfile(base::GenerateGUID(), "https://www.example.com/"));
   test::SetProfileInfo(profiles[1],
                        "John", "", "Doe", "dojo@example.com", "",
                        "88 Nowhere Ave.", "", "", "", "", "", "");
 
   // If the only name field in the suggested fields is the excluded field, we
   // should not fall back to the full name as a distinguishing field.
   std::vector<ServerFieldType> suggested_fields;
   suggested_fields.push_back(ADDRESS_HOME_LINE1);
   suggested_fields.push_back(ADDRESS_BILLING_LINE1);
   suggested_fields.push_back(EMAIL_ADDRESS);
   std::vector<base::string16> labels;
   AutofillProfile::CreateInferredLabels(profiles.get(), &suggested_fields,
-                                        UNKNOWN_TYPE, 2, &labels);
+                                        UNKNOWN_TYPE, 2, "en-US", &labels);
   ASSERT_EQ(2U, labels.size());
   EXPECT_EQ(ASCIIToUTF16("88 Nowhere Ave., doe@example.com"), labels[0]);
   EXPECT_EQ(ASCIIToUTF16("88 Nowhere Ave., dojo@example.com"), labels[1]);
 }
 
 // Make sure that empty fields are not treated as distinguishing fields.
 TEST(AutofillProfileTest, CreateInferredLabelsSkipsEmptyFields) {
   ScopedVector<AutofillProfile> profiles;
   profiles.push_back(
       new AutofillProfile(base::GenerateGUID(), "https://www.example.com/"));
   test::SetProfileInfo(profiles[0],
                        "John", "", "Doe", "doe@example.com",
                        "Gogole", "", "", "", "", "", "", "");
   profiles.push_back(
       new AutofillProfile(base::GenerateGUID(), "https://www.example.com/"));
   test::SetProfileInfo(profiles[1],
                        "John", "", "Doe", "doe@example.com",
                        "Ggoole", "", "", "", "", "", "", "");
   profiles.push_back(
       new AutofillProfile(base::GenerateGUID(), "https://www.example.com/"));
   test::SetProfileInfo(profiles[2],
                        "John", "", "Doe", "john.doe@example.com",
                        "Goolge", "", "", "", "", "", "", "");
 
   std::vector<base::string16> labels;
   AutofillProfile::CreateInferredLabels(profiles.get(), NULL, UNKNOWN_TYPE, 3,
-                                        &labels);
+                                        "en-US", &labels);
   ASSERT_EQ(3U, labels.size());
   EXPECT_EQ(ASCIIToUTF16("John Doe, doe@example.com, Gogole"), labels[0]);
   EXPECT_EQ(ASCIIToUTF16("John Doe, doe@example.com, Ggoole"), labels[1]);
   EXPECT_EQ(ASCIIToUTF16("John Doe, john.doe@example.com, Goolge"), labels[2]);
 
   // A field must have a non-empty value for each profile to be considered a
   // distinguishing field.
   profiles[1]->SetRawInfo(ADDRESS_HOME_LINE1, ASCIIToUTF16("88 Nowhere Ave."));
   AutofillProfile::CreateInferredLabels(profiles.get(), NULL, UNKNOWN_TYPE, 1,
-                                        &labels);
+                                        "en-US", &labels);
   ASSERT_EQ(3U, labels.size());
   EXPECT_EQ(ASCIIToUTF16("John Doe, doe@example.com, Gogole"), labels[0]);
   EXPECT_EQ(ASCIIToUTF16("John Doe, 88 Nowhere Ave., doe@example.com, Ggoole"),
             labels[1]) << labels[1];
   EXPECT_EQ(ASCIIToUTF16("John Doe, john.doe@example.com"), labels[2]);
 }
 
 // Test that labels that would otherwise have multiline values are flattened.
 TEST(AutofillProfileTest, CreateInferredLabelsFlattensMultiLineValues) {
   ScopedVector<AutofillProfile> profiles;
   profiles.push_back(
       new AutofillProfile(base::GenerateGUID(), "https://www.example.com/"));
   test::SetProfileInfo(profiles[0],
                        "John", "", "Doe", "doe@example.com", "",
                        "88 Nowhere Ave.", "Apt. 42", "", "", "", "", "");
 
   // If the only name field in the suggested fields is the excluded field, we
   // should not fall back to the full name as a distinguishing field.
   std::vector<ServerFieldType> suggested_fields;
   suggested_fields.push_back(NAME_FULL);
   suggested_fields.push_back(ADDRESS_HOME_STREET_ADDRESS);
   std::vector<base::string16> labels;
   AutofillProfile::CreateInferredLabels(profiles.get(), &suggested_fields,
-                                        NAME_FULL, 1, &labels);
+                                        NAME_FULL, 1, "en-US", &labels);
   ASSERT_EQ(1U, labels.size());
   EXPECT_EQ(ASCIIToUTF16("88 Nowhere Ave., Apt. 42"), labels[0]);
 }
 
 TEST(AutofillProfileTest, IsSubsetOf) {
   scoped_ptr<AutofillProfile> a, b;
 
   // |a| is a subset of |b|.
   a.reset(
       new AutofillProfile(base::GenerateGUID(), "https://www.example.com/"));
@@ skipping 26 matching lines @@
       NULL);
   EXPECT_FALSE(a->IsSubsetOf(*b, "en-US"));
 }
 
 TEST(AutofillProfileTest, OverwriteWithOrAddTo) {
   AutofillProfile a(base::GenerateGUID(), "https://www.example.com");
   test::SetProfileInfo(&a, "Marion", "Mitchell", "Morrison",
                        "marion@me.xyz", "Fox", "123 Zoo St.", "unit 5",
                        "Hollywood", "CA", "91601", "US",
                        "12345678910");
-  std::vector<base::string16> names;
-  a.GetRawMultiInfo(NAME_FULL, &names);
-  names.push_back(ASCIIToUTF16("Marion Morrison"));
-  a.SetRawMultiInfo(NAME_FULL, names);
+  std::vector<base::string16> first_names;
+  a.GetRawMultiInfo(NAME_FIRST, &first_names);
+  first_names.push_back(ASCIIToUTF16("Marion"));
+  a.SetRawMultiInfo(NAME_FIRST, first_names);
+
+  std::vector<base::string16> last_names;
+  a.GetRawMultiInfo(NAME_LAST, &last_names);
+  last_names[last_names.size() - 1] = ASCIIToUTF16("Morrison");
+  a.SetRawMultiInfo(NAME_LAST, last_names);
 
   // Create an identical profile except that the new profile:
   //   (1) Has a different origin,
   //   (2) Has a different address line 2,
   //   (3) Lacks a company name,
   //   (4) Has a different full name variant, and
   //   (5) Has a language code.
   AutofillProfile b = a;
   b.set_guid(base::GenerateGUID());
   b.set_origin("Chrome settings");
   b.SetRawInfo(ADDRESS_HOME_LINE2, ASCIIToUTF16("area 51"));
   b.SetRawInfo(COMPANY_NAME, base::string16());
-  b.GetRawMultiInfo(NAME_FULL, &names);
+
+  std::vector<base::string16> names;
+  b.GetMultiInfo(AutofillType(NAME_FULL), "en-US", &names);
   names.push_back(ASCIIToUTF16("Marion M. Morrison"));
   b.SetRawMultiInfo(NAME_FULL, names);
   b.set_language_code("en");
 
   a.OverwriteWithOrAddTo(b, "en-US");
   EXPECT_EQ("Chrome settings", a.origin());
   EXPECT_EQ(ASCIIToUTF16("area 51"), a.GetRawInfo(ADDRESS_HOME_LINE2));
   EXPECT_EQ(ASCIIToUTF16("Fox"), a.GetRawInfo(COMPANY_NAME));
-  a.GetRawMultiInfo(NAME_FULL, &names);
+  a.GetMultiInfo(AutofillType(NAME_FULL), "en-US", &names);
   ASSERT_EQ(3U, names.size());
   EXPECT_EQ(ASCIIToUTF16("Marion Mitchell Morrison"), names[0]);
   EXPECT_EQ(ASCIIToUTF16("Marion Morrison"), names[1]);
   EXPECT_EQ(ASCIIToUTF16("Marion M. Morrison"), names[2]);
   EXPECT_EQ("en", a.language_code());
 }
 
 TEST(AutofillProfileTest, AssignmentOperator) {
   AutofillProfile a(base::GenerateGUID(), "https://www.example.com/");
   test::SetProfileInfo(&a, "Marion", "Mitchell", "Morrison",
@@ skipping 455 matching lines @@
 
     for (size_t i = 0; i < current_case.expected_result.size(); ++i) {
       EXPECT_EQ(first_names[i], merged_first_names[i]);
       EXPECT_EQ(middle_names[i], merged_middle_names[i]);
       EXPECT_EQ(last_names[i], merged_last_names[i]);
     }
   }
 }
 
 }  // namespace autofill