autofill names - dont parse when calling SetRawInfo(FULL_NAME)

chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <map>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/callback.h"
 #include "base/command_line.h"
@@ skipping 1478 matching lines @@
     FormFieldData field;
     field.autocomplete_attribute.assign(attributes[i]);
     form_data.fields.push_back(field);
   }
 
   SetUpControllerWithFormData(form_data);
   SwitchToAutofill();
 
   // Billing.
   AutofillProfile test_profile(test::GetVerifiedProfile());
-  test_profile.SetRawInfo(NAME_FULL, ASCIIToUTF16("Fabian Jackson von Nacho"));
+  test_profile.SetInfo(AutofillType(NAME_FULL),
+                       ASCIIToUTF16("Fabian Jackson von Nacho"),
+                       "en-US");
   controller()->GetTestingManager()->AddTestingProfile(&test_profile);
 
   // Credit card.
   CreditCard credit_card(test::GetVerifiedCreditCard());
   controller()->GetTestingManager()->AddTestingCreditCard(&credit_card);
 
   // Make shipping name different from billing.
   AutofillProfile test_profile2(test::GetVerifiedProfile2());
-  test_profile2.SetRawInfo(NAME_FULL, ASCIIToUTF16("Don Ford"));
+  test_profile2.SetInfo(AutofillType(NAME_FULL),
+                        ASCIIToUTF16("Don Ford"),
+                        "en-US");
   controller()->GetTestingManager()->AddTestingProfile(&test_profile2);
   ui::MenuModel* shipping_model =
       controller()->MenuModelForSection(SECTION_SHIPPING);
   shipping_model->ActivatedAt(2);
 
   controller()->OnAccept();
 
   EXPECT_EQ(NAME_FULL, form_structure()->field(0)->Type().GetStorableType());
   EXPECT_EQ(ASCIIToUTF16("Don Ford"),
             form_structure()->field(0)->value);
@@ skipping 874 matching lines @@
   // And that the shipping suggestions menu has less selections.
   EXPECT_EQ(
       2, controller()->MenuModelForSection(SECTION_SHIPPING)->GetItemCount());
 
   // Additionally, editing fields should not show Autofill popups.
   ASSERT_NO_FATAL_FAILURE(controller()->UserEditedOrActivatedInput(
       SECTION_BILLING,
       NAME_BILLING_FULL,
       gfx::NativeView(),
       gfx::Rect(),
-      verified_profile.GetRawInfo(NAME_FULL).substr(0, 1),
+      verified_profile.GetInfo(AutofillType(NAME_FULL), "en-US").substr(0, 1),
       true));
   EXPECT_EQ(UNKNOWN_TYPE, controller()->popup_input_type());
 }
 
 // Tests that user is prompted when using instrument with minimal address.
 TEST_F(AutofillDialogControllerTest, UpgradeMinimalAddress) {
   // A minimal address being selected should trigger error validation in the
   // view. Called once for each incomplete suggestion.
   EXPECT_CALL(*controller()->GetView(), UpdateForErrors());
 
@@ skipping 509 matching lines @@
   AutofillProfile test_profile(test::GetVerifiedProfile());
   FillInputs(SECTION_BILLING, test_profile);
 
   UseBillingForShipping();
 
   controller()->GetView()->CheckSaveDetailsLocallyCheckbox(true);
   controller()->OnAccept();
 
   TestPersonalDataManager* test_pdm = controller()->GetTestingManager();
   const CreditCard& imported_card = test_pdm->imported_credit_card();
-  EXPECT_EQ(test_profile.GetRawInfo(NAME_FULL),
+  EXPECT_EQ(test_profile.GetInfo(AutofillType(NAME_FULL), "en-US"),
             imported_card.GetRawInfo(CREDIT_CARD_NAME));
 }
 
 TEST_F(AutofillDialogControllerTest, SaveCreditCardIncludesName_WithBilling) {
   SwitchToAutofill();
 
   TestPersonalDataManager* test_pdm = controller()->GetTestingManager();
   AutofillProfile test_profile(test::GetVerifiedProfile());
 
   EXPECT_CALL(*controller()->GetView(), ModelChanged());
   test_pdm->AddTestingProfile(&test_profile);
   ASSERT_TRUE(controller()->MenuModelForSection(SECTION_BILLING));
 
   CreditCard test_credit_card(test::GetVerifiedCreditCard());
   FillInputs(SECTION_CC, test_credit_card);
 
   controller()->GetView()->CheckSaveDetailsLocallyCheckbox(true);
   controller()->OnAccept();
 
   const CreditCard& imported_card = test_pdm->imported_credit_card();
-  EXPECT_EQ(test_profile.GetRawInfo(NAME_FULL),
+  EXPECT_EQ(test_profile.GetInfo(AutofillType(NAME_FULL), "en-US"),
             imported_card.GetRawInfo(CREDIT_CARD_NAME));
 
   controller()->ViewClosed();
 }
 
 TEST_F(AutofillDialogControllerTest, InputEditability) {
   // Empty wallet items: all fields are editable.
   scoped_ptr<wallet::WalletItems> items =
       wallet::GetTestWalletItems(wallet::AMEX_DISALLOWED);
   controller()->OnDidGetWalletItems(items.Pass());
@@ skipping 388 matching lines @@
     const ServerFieldType type = inputs[i].type;
     outputs[type] = full_profile.GetInfo(AutofillType(type), "en-US");
   }
   controller()->GetView()->SetUserInput(SECTION_SHIPPING, outputs);
   controller()->GetView()->CheckSaveDetailsLocallyCheckbox(true);
   controller()->OnAccept();
 
   // Profiles saved while rules are unavailable shouldn't be verified.
   const AutofillProfile& imported_profile =
       controller()->GetTestingManager()->imported_profile();
-  ASSERT_EQ(imported_profile.GetRawInfo(NAME_FULL),
-            full_profile.GetRawInfo(NAME_FULL));
+  ASSERT_EQ(imported_profile.GetInfo(AutofillType(NAME_FULL), "en-US"),
+            full_profile.GetInfo(AutofillType(NAME_FULL), "en-US"));
   EXPECT_EQ(imported_profile.origin(), GURL(kSourceUrl).GetOrigin().spec());
   EXPECT_FALSE(imported_profile.IsVerified());
 }
 
 TEST_F(AutofillDialogControllerTest, LimitedCountryChoices) {
   ui::ComboboxModel* shipping_country_model =
       controller()->ComboboxModelForAutofillType(ADDRESS_HOME_COUNTRY);
   const int default_number_of_countries =
       shipping_country_model->GetItemCount();
   // We show a lot of countries by default, but the exact number doesn't matter.
@@ skipping 287 matching lines @@
   EXPECT_EQ(ASCIIToUTF16("United States"), form_structure()->field(2)->value);
   EXPECT_EQ(ADDRESS_HOME_COUNTRY,
             form_structure()->field(3)->Type().GetStorableType());
   EXPECT_EQ(ASCIIToUTF16("US"), form_structure()->field(3)->value);
   EXPECT_EQ(ADDRESS_HOME_COUNTRY,
             form_structure()->field(4)->Type().GetStorableType());
   EXPECT_EQ(ASCIIToUTF16("United States"), form_structure()->field(4)->value);
 }
 
 }  // namespace autofill