Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 347173002: Revert of Add unittest for OpenTypeSanitizer (Closed)

Created:
6 years, 6 months ago by jamesr
Modified:
6 years, 6 months ago
CC:
blink-reviews, krit, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis, Kunihiko Sakamoto
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Revert of Add unittest for OpenTypeSanitizer (https://codereview.chromium.org/316343004/) Reason for revert: Crashes on WebKit Android (Nexus4) bot: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/14966 [----------] 1 test from OpenTypeSanitizerTest [ RUN ] OpenTypeSanitizerTest.TestWOFF ../../third_party/WebKit/Source/platform/fonts/opentype/OpenTypeSanitizerTest.cpp:54: Failure Expected: (buffer->size()) >= (4u), actual: 0 vs 4 [ CRASHED ] Original issue's description: > Add unittest for OpenTypeSanitizer > > Since TestingPlatformSupport::unitTestSupport() doesn't implement required methods(webKitRootDir and readFromFile), I needed to put this test in platform_web_unittest_files. > > BUG=371267 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176593 TBR=jamesr@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176638

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -88 lines) Patch
M Source/platform/blink_platform.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/fonts/opentype/OpenTypeSanitizer.h View 1 chunk +1 line, -2 lines 0 comments Download
D Source/platform/fonts/opentype/OpenTypeSanitizerTest.cpp View 1 chunk +0 lines, -85 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
jamesr
Created Revert of Add unittest for OpenTypeSanitizer
6 years, 6 months ago (2014-06-20 19:32:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/347173002/1
6 years, 6 months ago (2014-06-20 19:33:42 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-20 19:33:43 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 6 months ago (2014-06-20 19:33:44 UTC) #4
jamesr
On 2014/06/20 19:33:44, I haz the power (commit-bot) wrote: > No LGTM from a valid ...
6 years, 6 months ago (2014-06-20 19:34:26 UTC) #5
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 6 months ago (2014-06-20 19:34:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/347173002/1
6 years, 6 months ago (2014-06-20 19:35:42 UTC) #7
jamesr
The CQ bit was unchecked by jamesr@chromium.org
6 years, 6 months ago (2014-06-20 19:45:50 UTC) #8
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 6 months ago (2014-06-20 19:45:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/347173002/1
6 years, 6 months ago (2014-06-20 19:46:03 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-06-20 19:46:51 UTC) #11
Message was sent while issue was closed.
Change committed as 176638

Powered by Google App Engine
This is Rietveld 408576698