Source/core/inspector/InspectorDOMAgent.cpp - Issue 347143002: DevTools: Screencast view scaling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/InspectorDOMAgent.cpp

Issue 347143002: DevTools: Screencast view scaling (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Used new ScreencastFrameMetadata params. Fixed zoom. getNodeForLocation works expects CSS coords now Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/inspector/InspectorDOMAgent.cpp

diff --git a/Source/core/inspector/InspectorDOMAgent.cpp b/Source/core/inspector/InspectorDOMAgent.cpp

index 8541804f0f6467bcea4ba1efcdfc9ebb8935fb92..ec696c648e6584d2bd66670ba54d110ee83daa06 100644

--- a/Source/core/inspector/InspectorDOMAgent.cpp

+++ b/Source/core/inspector/InspectorDOMAgent.cpp

@@ -1411,8 +1411,12 @@ void InspectorDOMAgent::getNodeForLocation(ErrorString* errorString, int x, int

{

if (!pushDocumentUponHandlelessOperation(errorString))

return;

- Node* node = hoveredNodeForPoint(m_document->frame(), IntPoint(x, y), false);

+ HitTestRequest request(HitTestRequest::Move | HitTestRequest::ReadOnly | HitTestRequest::AllowChildFrameContent);

+ HitTestResult result(IntPoint(x, y));

+ m_document->renderView()->hitTest(request, result);

dgozman 2014/06/26 11:34:21 Why not m_document->frame()->contentRenderer()->hi

vkuzkokov 2014/06/26 14:15:54 OK.

+ Node* node = result.innerPossiblyPseudoNode();

+ while (node && node->nodeType() == Node::TEXT_NODE)

+ node = node->parentNode();

if (!node) {

*errorString = "No node found at given location";

return;