Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 347123002: Revert 278655 "Include loaded modules in safe browsing client in..." (Closed)

Created:
6 years, 6 months ago by yzshen1
Modified:
6 years, 6 months ago
Reviewers:
pmonette
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 278655 "Include loaded modules in safe browsing client in..." > Include loaded modules in safe browsing client incident reports. > > This includes the sanitized paths of all loaded modules and an > indication for those that host active LSPs. > > BUG=386156 > > Review URL: https://codereview.chromium.org/323953002 TBR=pmonette@google.com,grt@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278721

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -342 lines) Patch
M trunk/src/chrome/browser/safe_browsing/environment_data_collection_win.h View 1 chunk +1 line, -10 lines 0 comments Download
M trunk/src/chrome/browser/safe_browsing/environment_data_collection_win.cc View 1 chunk +1 line, -82 lines 0 comments Download
D trunk/src/chrome/browser/safe_browsing/environment_data_collection_win_unittest.cc View 1 chunk +0 lines, -113 lines 0 comments Download
D trunk/src/chrome/browser/safe_browsing/path_sanitizer.h View 1 chunk +0 lines, -31 lines 0 comments Download
D trunk/src/chrome/browser/safe_browsing/path_sanitizer.cc View 1 chunk +0 lines, -30 lines 0 comments Download
D trunk/src/chrome/browser/safe_browsing/path_sanitizer_unittest.cc View 1 chunk +0 lines, -59 lines 0 comments Download
M trunk/src/chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/chrome/common/safe_browsing/csd.proto View 3 chunks +2 lines, -13 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
yzshen1
6 years, 6 months ago (2014-06-20 16:38:22 UTC) #1
yzshen1
Committed patchset #1 manually as r278721 (tree was closed).
6 years, 6 months ago (2014-06-20 16:38:29 UTC) #2
yzshen1
6 years, 6 months ago (2014-06-20 16:38:58 UTC) #3
http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%283%29/builds...

(view as text)
SafeBrowsingEnvironmentDataCollectionWinTest.RecordLspFeature (run #1):
[ RUN      ] SafeBrowsingEnvironmentDataCollectionWinTest.RecordLspFeature
c:\b\build\slave\win_builder\build\src\chrome\browser\safe_browsing\environment_data_collection_win_unittest.cc(112):
error: Value of: lsp_feature_found
  Actual: false
Expected: true
[  FAILED  ] SafeBrowsingEnvironmentDataCollectionWinTest.RecordLspFeature
(235 ms)

SafeBrowsingEnvironmentDataCollectionWinTest.RecordLspFeature (run #2):
[ RUN      ] SafeBrowsingEnvironmentDataCollectionWinTest.RecordLspFeature
c:\b\build\slave\win_builder\build\src\chrome\browser\safe_browsing\environment_data_collection_win_unittest.cc(112):
error: Value of: lsp_feature_found
  Actual: false
Expected: true
[  FAILED  ] SafeBrowsingEnvironmentDataCollectionWinTest.RecordLspFeature
(187 ms)

SafeBrowsingEnvironmentDataCollectionWinTest.RecordLspFeature (run #3):
[ RUN      ] SafeBrowsingEnvironmentDataCollectionWinTest.RecordLspFeature
c:\b\build\slave\win_builder\build\src\chrome\browser\safe_browsing\environment_data_collection_win_unittest.cc(112):
error: Value of: lsp_feature_found
  Actual: false
Expected: true
[  FAILED  ] SafeBrowsingEnvironmentDataCollectionWinTest.RecordLspFeature
(47 ms)

SafeBrowsingEnvironmentDataCollectionWinTest.RecordLspFeature (run #4):
[ RUN      ] SafeBrowsingEnvironmentDataCollectionWinTest.RecordLspFeature
c:\b\build\slave\win_builder\build\src\chrome\browser\safe_browsing\environment_data_collection_win_unittest.cc(112):
error: Value of: lsp_feature_found
  Actual: false
Expected: true
[  FAILED  ] SafeBrowsingEnvironmentDataCollectionWinTest.RecordLspFeature
(32 ms)


On Fri, Jun 20, 2014 at 9:38 AM, <yzshen@chromium.org> wrote:

> Committed patchset #1 manually as r278721 (tree was closed).
>
> https://codereview.chromium.org/347123002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698