chrome/browser/guest_view/guest_view_base.cc - Issue 347113002: Refactor PluginPermissionHelper as WebViewPermissionHelper

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/guest_view/guest_view_base.cc

Issue 347113002: Refactor PluginPermissionHelper as WebViewPermissionHelper (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Small changes are made. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/guest_view/guest_view_base.h ('k') | chrome/browser/guest_view/web_view/javascript_dialog_helper.h » ('j') | chrome/browser/guest_view/web_view/web_view_permission_helper.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/guest_view/guest_view_base.cc

diff --git a/chrome/browser/guest_view/guest_view_base.cc b/chrome/browser/guest_view/guest_view_base.cc

index 2b335016103e3249da6db11bd06b7678623008e5..69c4d9990f4708878f42670d18bbc6e3395e1d9f 100644

--- a/chrome/browser/guest_view/guest_view_base.cc

+++ b/chrome/browser/guest_view/guest_view_base.cc

@@ -302,7 +302,7 @@ GuestViewBase::~GuestViewBase() {

pending_events_.clear();

}

-void GuestViewBase::DispatchEvent(Event* event) {

+void GuestViewBase::DispatchEventToEmbedder(Event* event) {

scoped_ptr<Event> event_ptr(event);

if (!in_extension()) {

NOTREACHED();

@@ -337,7 +337,7 @@ void GuestViewBase::SendQueuedEvents() {

while (!pending_events_.empty()) {

linked_ptr<Event> event_ptr = pending_events_.front();

pending_events_.pop_front();

- DispatchEvent(event_ptr.release());

+ DispatchEventToEmbedder(event_ptr.release());

}