Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4944)

Unified Diff: chrome/browser/geolocation/geolocation_permission_context_extensions.cc

Issue 347113002: Refactor PluginPermissionHelper as WebViewPermissionHelper (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changes are made. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/geolocation/geolocation_permission_context_extensions.cc
diff --git a/chrome/browser/geolocation/geolocation_permission_context_extensions.cc b/chrome/browser/geolocation/geolocation_permission_context_extensions.cc
index 8a99a3919ac3b32844f0e73661f912f2648e318f..e0496b19cb94ff64d90100ec16c05fbb4ae5cc05 100644
--- a/chrome/browser/geolocation/geolocation_permission_context_extensions.cc
+++ b/chrome/browser/geolocation/geolocation_permission_context_extensions.cc
@@ -9,7 +9,7 @@
#if defined(ENABLE_EXTENSIONS)
#include "chrome/browser/content_settings/permission_request_id.h"
#include "chrome/browser/extensions/suggest_permission_util.h"
-#include "chrome/browser/guest_view/web_view/web_view_guest.h"
+#include "chrome/browser/guest_view/web_view/web_view_permission_helper.h"
#include "chrome/browser/profiles/profile.h"
#include "extensions/browser/extension_registry.h"
#include "extensions/browser/process_map.h"
@@ -41,12 +41,11 @@ bool GeolocationPermissionContextExtensions::RequestPermission(
#if defined(ENABLE_EXTENSIONS)
GURL requesting_frame_origin = requesting_frame.GetOrigin();
- WebViewGuest* guest = WebViewGuest::FromWebContents(web_contents);
- if (guest) {
- guest->RequestGeolocationPermission(bridge_id,
- requesting_frame,
- user_gesture,
- callback);
+ WebViewPermissionHelper* web_view_permission_helper =
+ WebViewPermissionHelper::FromWebContents(web_contents);
+ if (web_view_permission_helper) {
+ web_view_permission_helper->RequestGeolocationPermission(
+ bridge_id, requesting_frame, user_gesture, callback);
*permission_set = false;
*new_permission = false;
return true;
@@ -91,10 +90,11 @@ bool GeolocationPermissionContextExtensions::CancelPermissionRequest(
content::WebContents* web_contents,
int bridge_id) {
#if defined(ENABLE_EXTENSIONS)
- WebViewGuest* guest =
- web_contents ? WebViewGuest::FromWebContents(web_contents) : NULL;
- if (guest) {
- guest->CancelGeolocationPermissionRequest(bridge_id);
+ WebViewPermissionHelper* web_view_permission_helper =
+ web_contents ? WebViewPermissionHelper::FromWebContents(web_contents)
+ : NULL;
+ if (web_view_permission_helper) {
+ web_view_permission_helper->CancelGeolocationPermissionRequest(bridge_id);
return true;
}
#endif // defined(ENABLE_EXTENSIONS)

Powered by Google App Engine
This is Rietveld 408576698